[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbeb3d029d8e: Add missing vrnd intrinsics (authored by miyengar, committed by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

This revision was automatically updated to reflect the committed changes. vhscampos marked an inline comment as done. Closed by commit rGd77cba6d474a: [Clang][DebugInfo] Emit narrower base types for structured binding declarations… (authored by vhscampos). Repository: rG LLVM Github Monorepo

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked an inline comment as done. vhscampos added a comment. @aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work. For the time being, we believe it is better to have no debug information rather than

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 550298. vhscampos added a comment. - Redone test to cover only what's needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 Files:

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked 3 inline comments as done. vhscampos added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:6 + unsigned int y : 16; +}; + tmatheson wrote: > This would be easier to check if the structs had

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 549359. vhscampos added a comment. - Addressed the one comment regarding code. - Changed the test to use update_cc_test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos created this revision. Herald added a project: All. vhscampos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In cases where a structured binding declaration is made to a struct with bitfields: struct A { unsigned int x : 16;

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d1ff787e5c2: [AArch64] Add support for the Cortex-X3 CPU (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 474029. vhscampos added a comment. Rebasing and conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added a comment. @tschuett Do you want me to put the note about 'native' detection for neoverse-v2 back? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472583. vhscampos added a comment. Added SSBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos marked an inline comment as done. vhscampos added inline comments. Comment at: clang/docs/ReleaseNotes.rst:696 -- Add driver and tuning support for Neoverse V2 via the flag ``-mcpu=neoverse-v2``. - Native detection is also supported via ``-mcpu=native``.

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472567. vhscampos added a comment. Added AEK_FLAM to the list of features for Cortex-X3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files:

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

vhscampos added inline comments. Comment at: clang/docs/ReleaseNotes.rst:699 + + * Arm cortex-A715 (cortex-a715). Please capitalise the first cortex-A715. It should be "Arm Cortex-A715". Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 472001. vhscampos added a comment. Combining release notes of Cortex-X3 and Neoverse V2. Make cortex-x3 use neoverse-v2 model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos planned changes to this revision. vhscampos added a comment. We found an issue in the list of target features for v9-A. This patch will be affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + vhscampos wrote: > dmgreen wrote: > > Can you add a reference to neoverse-v2 too. > I could do this in another patch, but I prefer to restrict

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:84 +* Added support for the Cortex-X3 CPU. + dmgreen wrote: > Can you add a reference to neoverse-v2 too. I could do this in another patch, but I prefer to restrict this one to X3.

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 470449. vhscampos marked 2 inline comments as done. vhscampos added a comment. Comments addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files:

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Cortex-X3 is an Armv9-A AArch64 CPU. This patch

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

vhscampos added a comment. For reference, another small reproducer of the crash, but with a different stack trace than the first example posted here: // Must compile with -std=c++03 to crash #include int main(int, char**) { int i[3] = {1, 2, 3}; int j[3] = {4, 5, 6};

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

vhscampos added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitter(*this, nullptr); + return

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

vhscampos added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217 assert(E->isFileScope() && "not a file-scope compound literal expr"); - return tryEmitGlobalCompoundLiteral(*this, nullptr, E); + ConstantEmitter emitter(*this, nullptr); + return

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121983/new/ https://reviews.llvm.org/D121983

[PATCH] D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118757/new/ https://reviews.llvm.org/D118757

[PATCH] D116153: [ARM][AArch64] Add missing v8.x checks

vhscampos added a comment. I don't see any problem with the patch, but we should wait on @SjoerdMeijer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116153/new/ https://reviews.llvm.org/D116153 ___ cfe-commits mailing list

[PATCH] D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE

vhscampos added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:929-949 + if (ArchKind == llvm::ARM::ArchKind::ARMV8A || + ArchKind == llvm::ARM::ArchKind::ARMV8R || + ArchKind == llvm::ARM::ArchKind::ARMV8_1A || + ArchKind ==

[PATCH] D115507: Add PACBTI-M support to LLVM release notes.

vhscampos accepted this revision. vhscampos added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115507/new/ https://reviews.llvm.org/D115507

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

vhscampos added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2979 +def warn_unsupported_branch_protection_spec : Warning< + "unsupported branch protection specification '%0'">, InGroup; + Still need to remove extraneous

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

vhscampos added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:134-135 StringRef ) const { - llvm::AArch64::ParsedBranchProtection PBP; - if (!llvm::AArch64::parseBranchProtection(Spec, PBP, Err)) +

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

vhscampos added inline comments. Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:4083 def : t2InstAlias<"csdb$p", (t2HINT 20, pred:$p), 1>; +def : t2InstAlias<"pacbti$p r12,lr,sp", (t2HINT 13, pred:$p), 1>; +def : t2InstAlias<"bti$p", (t2HINT 15, pred:$p), 1>;

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7cf33a8376: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang (authored by vhscampos). Repository: rG LLVM Github

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A (authored by vhscampos). Repository: rG LLVM Github Monorepo

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos added a comment. To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano The cryptographic extensions will **//NOT//** be enabled by default on Armv9-A and on Armv9-A ARM CPUs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 376228. vhscampos edited the summary of this revision. vhscampos added a comment. 1. Disable the cryptographic extensions by default. 2. Small fix in TargetParserTest.cpp to include different spellings of the -march values. Repository: rG LLVM Github

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

vhscampos updated this revision to Diff 374207. vhscampos added a comment. Added 'the' for better phrasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110241/new/ https://reviews.llvm.org/D110241 Files: clang/docs/ReleaseNotes.rst

[PATCH] D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang

vhscampos created this revision. Herald added a subscriber: kristof.beyls. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110241 Files:

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 374162. vhscampos added a comment. Add missing . to end of sentences in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109517/new/ https://reviews.llvm.org/D109517 Files:

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos requested review of this revision. vhscampos added a comment. Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 373943. vhscampos added a comment. 1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:413 - auto V8_6Pos = llvm::find(Features, "+v8.6a"); - if (V8_6Pos != std::end(Features)) -V8_6Pos = Features.insert(std::next(V8_6Pos), {"+i8mm", "+bf16"}); + const char *Archs[]

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos updated this revision to Diff 372473. vhscampos marked 3 inline comments as done. vhscampos added a comment. 1. Enable the SVE2 extension as default. 2. Remove out of date comments in tests. 3. Remove unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

vhscampos created this revision. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. armv9-a, armv9.1-a and armv9.2-a can be targeted using the -march

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rGee3e01627ff8: [Clang][ARM] Define __VFP_FP__ macro unconditionally (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos added a comment. Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos updated this revision to Diff 337723. vhscampos added a comment. Add a clarifying comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100372/new/ https://reviews.llvm.org/D100372 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally

vhscampos created this revision. Herald added subscribers: danielkiss, kristof.beyls. vhscampos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang only defines __VFP_FP__ when the FPU is enabled. However, gcc defines it unconditionally.

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

vhscampos added a comment. @Tyker This is causing another build failure in another example: [2858/4034] Building CXX object tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o FAILED: tools/clang/examples/Attribute/CMakeFiles/Attribute.dir/Attribute.cpp.o

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos added a comment. Not really. Closing it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82949/new/ https://reviews.llvm.org/D82949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1a3396bfbc6: [Driver][ARM] Disable unsupported features when nofp arch extension is used (authored by vhscampos). Changed prior to commit:

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos updated this revision to Diff 280072. vhscampos added a comment. 1. Add comment explaining the MVE-Integer detail. 2. Add another test to check the disabled features. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82948/new/

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82948/new/ https://reviews.llvm.org/D82948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos updated this revision to Diff 275392. vhscampos added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. 1. Merged the second patch into this (handle bf16). 2. Do the same treatment for -mcpu. 3. Instead of doing string search once again, return

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:292-297 + auto checkFPDisabledInArchName = [](const StringRef ) { +SmallVector Split; +ArchName.split(Split, '+', -1, false); +return

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos marked 2 inline comments as done. vhscampos added a comment. I will merge the two patches into one. Please also see my inline responses. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:288 +static void appendNoFPUnsupportedFeatures(const arm::FloatABI ABI, +

[PATCH] D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos abandoned this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82946 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos added a child revision: D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing. vhscampos added a reviewer: chill. A list of target features

[PATCH] D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing

vhscampos created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vhscampos retitled this revision from "Disable bf16 when hardware FP support is missing" to "[Driver][ARM] Disable bf16 when hardware FP support is missing". vhscampos edited the summary of

[PATCH] D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos abandoned this revision. A list of target features is disabled when there is no hardware floating-point support. This is the case when one of the following

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b090db0df47: [ARM] Improve diagnostics message when Neon is unsupported (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81847/new/

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos added a reviewer: stuij. Whenever Neon is not supported, a generic message is printed: error: "NEON support not enabled" Followed by a series of other

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf11c5e86ce: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

vhscampos created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add support for vcadd_* family of intrinsics. This set of intrinsics is available in Armv8.3-A. The fp16 versions require the FP16 extension, which

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6e11a36c49c: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d35b7d9e1a3: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf __arm_wsrf64 (authored by vhscampos). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

vhscampos marked an inline comment as done. vhscampos added a comment. Added support for `__clsll` as requested. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos updated this revision to Diff 226430. vhscampos added a comment. Add support for __clsll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69250/new/ https://reviews.llvm.org/D69250 Files: clang/include/clang/Basic/BuiltinsAArch64.def

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos updated this revision to Diff 226406. vhscampos added a comment. Use __builtin_bit_cast to perform the relevant bitcasts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 Files:

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos marked 2 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > vhscampos wrote: > > compnerd

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos updated this revision to Diff 226015. vhscampos added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 Files: clang/lib/Headers/arm_acle.h

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

vhscampos created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Adding support for ACLE intrinsics. Patch by Michael Platings. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69297 Files: clang/lib/Headers/arm_acle.h

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos marked 4 inline comments as done. vhscampos added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); compnerd wrote: > I don't see a pattern match for

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

vhscampos created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Writing support for two ACLE functions: unsigned int __cls(uint32_t x) unsigned int __clsl(unsigned long x) CLS stands for "Count number of