r286224 - Test commit of vbyakovl.

Author: vbyakovl Date: Tue Nov 8 04:32:10 2016 New Revision: 286224 URL: http://llvm.org/viewvc/llvm-project?rev=286224=rev Log: Test commit of vbyakovl. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787 } +if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) { + const BuiltinType *LHSBT = LHSEleType->getAs(); bruno wrote: > vbyakovlcl wrote: > > bruno wrote: > > >

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787 } +if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) { + const BuiltinType *LHSBT = LHSEleType->getAs(); bruno wrote: > vbyakovlcl wrote: > > bruno wrote: > > >

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl updated this revision to Diff 74269. https://reviews.llvm.org/D24669 Files: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index:

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306 + "vector operands do not have the same elements sizes (%0 and %1)">, + InGroup>, DefaultError; def

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl updated this revision to Diff 74123. https://reviews.llvm.org/D24669 Files: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index:

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. > ahatanak wrote in SemaExpr.cpp:8787 > Is it possible to use ASTContext::getTypeSize here? You are right. https://reviews.llvm.org/D24669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl updated this revision to Diff 73642. https://reviews.llvm.org/D24669 Files: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index:

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl removed rL LLVM as the repository for this revision. vbyakovlcl updated this revision to Diff 73468. https://reviews.llvm.org/D24669 Files: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/Sema/vecshift.c

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. > aaron.ballman wrote in DiagnosticGroups.td:522 > I would not add this as a diagnostic group, but instead use an ad-hoc group > on the diagnostic itself. I don't think this is going to see very many > diagnostics covered by the same group, but if that turns

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticGroups.td:522 @@ -521,2 +521,3 @@ def GNUZeroVariadicMacroArguments : DiagGroup<"gnu-zero-variadic-macro-arguments">; +def GNUVecElemSize : DiagGroup<"gnu-vec-elem-size">; def Fallback

Re: [PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl added a comment. Clang 3.8 balances vector shift operand erroneous using CheckVectorOperands which converts one of operand to the type of another. In https://reviews.llvm.org/D21678 it was fixed by using checkVectorShift instead. As result clang does not emit error if shift operands

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

vbyakovlcl created this revision. vbyakovlcl added reviewers: aaron.ballman, ahatanak. vbyakovlcl added a subscriber: cfe-commits. vbyakovlcl set the repository for this revision to rL LLVM. Gcc prints error if elements of left and right parts of a shift have different sizes. This patch is

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl updated this revision to Diff 71545. https://reviews.llvm.org/D24467 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/test/CodeGen/vecshift.c:43 @@ +42,3 @@ + vi8 = 1 << vi8; +// CHECK: [[t2:%.+]] = load <8 x i32>, <8 x i32>* @vi8, align 32 +// CHECK: shl <8 x i32> , [[t2]] ahatanak wrote: > This test fails on my

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl updated this revision to Diff 71498. https://reviews.llvm.org/D24467 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/CodeGen/vecshift.c llvm/tools/clang/test/Sema/vecshift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8790 @@ -8774,3 +8789,3 @@ S.Context.getExtVectorType(RHSEleType, LHSVecTy->getNumElements()); RHS = S.ImpCastExprToType(RHS.get(), VecTy, CK_VectorSplat); }

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8733 @@ -8731,2 +8732,3 @@ if (!IsCompAssign) { -LHS = S.UsualUnaryConversions(LHS.get()); +if (S.LangOpts.OpenCL || S.LangOpts.ZVector) + LHS =

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl removed rL LLVM as the repository for this revision. vbyakovlcl changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". vbyakovlcl updated this revision to Diff 71135. https://reviews.llvm.org/D24467 Files:

[PATCH] D24467: Fix an error after D21678

vbyakovlcl created this revision. vbyakovlcl added reviewers: ahatanak, aaron.ballman. vbyakovlcl added subscribers: andreybokhanko, cfe-commits. vbyakovlcl set the repository for this revision to rL LLVM. vbyakovlcl changed the visibility of this Differential Revision from "Public (No Login

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

I'll fix this. Vladimir --- From: *Akira Hatanaka* Date: Fri, Sep 2, 2016 at 3:00 AM Subject: Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values To:

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683 @@ -8680,5 +8676,3 @@ } -return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign, - /*AllowBothBool*/true, -

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8597 @@ -8596,4 +8596,3 @@ ///by a scalar or vector shift amount. -static QualType checkOpenCLVectorShift(Sema , - ExprResult , ExprResult , -

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl set the repository for this revision to rL LLVM. vbyakovl updated this revision to Diff 67140. Repository: rL LLVM https://reviews.llvm.org/D21678 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/Sema/shift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl added a comment. Someone, please review this. https://reviews.llvm.org/D21678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl added a comment. Ping! https://reviews.llvm.org/D21678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl updated this revision to Diff 62464. http://reviews.llvm.org/D21678 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/Sema/shift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp === ---

Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of vector values

vbyakovl updated this revision to Diff 62345. http://reviews.llvm.org/D21678 Files: llvm/tools/clang/lib/Sema/SemaExpr.cpp llvm/tools/clang/test/Sema/shift.c Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp === ---

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

vbyakovl added a comment. @rsmith ping http://reviews.llvm.org/D18823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

vbyakovl added a comment. Richard, now my changes are good for you? http://reviews.llvm.org/D18823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

vbyakovl updated this revision to Diff 53658. vbyakovl added a comment. Sema/SemaType.cpp: Deleted POD type and default constructor checkings. test/SemaCXX/c99-variable-length-array-cxx11.cpp: Edited dianocnics. http://reviews.llvm.org/D18823 Files: llvm/tools/clang/lib/CodeGen/CGClass.cpp

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

vbyakovl updated this revision to Diff 53548. vbyakovl added a comment. Sema/SemaType.cpp: Vla works in C++ by default. An error is printed if a class has not default constructor. test/SemaCXX/c99-variable-length-array.cpp: Changes is removed test/SemaCXX/vla.cpp: changes is removed.

[PATCH] D18823: Implementation of VlA of GNU C++ extension

vbyakovl created this revision. vbyakovl added a reviewer: aaron.s.wishnick. vbyakovl added subscribers: DmitryPolukhin, cfe-commits. This implements GNU C++ extension "Variable length array". This works under -std=gnu++98. http://reviews.llvm.org/D18823 Files: