[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added a comment. Thanks @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef536a12ea6: [UBSan] Disable the function and kcfi sanitizers on an execute-only target. (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 554665. MaggieYi marked 5 inline comments as done. MaggieYi added a comment. Thanks @MaskRay. The patch is updated. Hi @simon_tatham, are you happy with the patch? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:326 def err_unsupported_abi_for_opt : Error<"'%0' can only be used with the '%1' ABI">; +def err_unsupported_opt_for_execute_only_target +: Error<"unsupported option '%0' for the

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 554474. MaggieYi marked 7 inline comments as done. MaggieYi added a comment. Thanks @MaskRay, I have updated the patch following your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 Files:

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added a comment. Thanks @simon_tatham and @MaskRay for the quick code review. When I work on this issue, I want to add an error for both clang and clang -cc1. `-mexecute-only` is an ARM-only compiler option. The clang Driver will convert `-mexecute-only` to `-target-feature

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 553409. MaggieYi edited the summary of this revision. MaggieYi added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. The changes include: 1. Added an ARM::supportedExecuteOnly function to avoid the duplicated

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi created this revision. MaggieYi added reviewers: MaskRay, peter.smith, vitalybuka, probinson, pgousseau, glandium, uabelho. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PR for

[PATCH] D148410: [Parse] Remove TimeTraceScope for "ParseTemplate"

MaggieYi added a comment. Thanks @MaskRay, the fix is fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148410/new/ https://reviews.llvm.org/D148410 ___ cfe-commits mailing list

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Gentle ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147520/new/ https://reviews.llvm.org/D147520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. Analysis the issue using the above simple example: When clang parses the first line (`#include "1.h"`) in the `main.cpp`, a time section entry is created and put on the top of the time-trace stack. Assuming this time section entry is named `Source-1.h`, which has its

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi added a comment. A simple test to reproduce the issue: % cat main.cpp #include "1.h" #include "2.h" int foo(); % cat 1.h template auto Zero() -> T { return T{}; } %cat 2.h struct Bla {}; Compile the code with `-ftime-trace-granularity=0 -ftime-trace` to show the

[PATCH] D147520: Fix a time-trace issue of incorrect header hierarchy when a header contains a template function for its last symbol.

MaggieYi created this revision. MaggieYi added reviewers: Whitney, jamieschmeiser, MaskRay, rnk, aras-p, anton-afanasyev. Herald added a subscriber: hiraditya. Herald added a project: All. MaggieYi requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

This revision was automatically updated to reflect the committed changes. MaggieYi marked an inline comment as done. Closed by commit rG94dd4766a61b: [Coverage] Fix an issue: a statement after calling assert() function is… (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi marked an inline comment as done. MaggieYi added inline comments. Comment at: clang/test/CoverageMapping/terminate-statements.cpp:335 + ( true ? void (0) : abort() ); // CHECK: Gap,File 0, [[@LINE]]:33 -> [[@LINE+1]]:3 = #1 + ( false ? void (0) : abort() ); //

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi updated this revision to Diff 501509. MaggieYi added a comment. Thanks Zequan. I have added two tests following your suggestion. Kind regards, Maggie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 Files:

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi added a comment. Gentle ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144371/new/ https://reviews.llvm.org/D144371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144371: [LLVM-COV] Fix an issue: a statement after calling 'assert()' function is wrongly marked as 'not executed'

MaggieYi created this revision. MaggieYi added reviewers: vsk, zequanwu. MaggieYi added a project: clang. Herald added a project: All. MaggieYi requested review of this revision. Herald added a subscriber: cfe-commits. In the current coverage mapping implementation, we terminate the current

[PATCH] D133191: Driver test: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow, dyung. Herald added a subscriber: pengfei. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When testing clang that has been

[PATCH] D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e5fe1cdacdc: Remove `REQUIRES: x86-registered-target` from ps4/ps5 driver tests (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests.

MaggieYi added a comment. Thanks Paul. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132950/new/ https://reviews.llvm.org/D132950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132950: Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests.

MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow. Herald added a subscriber: pengfei. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some PS4/PS45 tests include the line

[PATCH] D130493: Disable stack-sizes section by default for PS4.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe191dfa79b: Disable stack-sizes section by default for PS4. (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130493: Disable stack-sizes section by default for PS4.

MaggieYi updated this revision to Diff 447756. MaggieYi added a comment. Use `Args.addOptInFlag` instead of `Args.hasFlag`, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130493/new/ https://reviews.llvm.org/D130493 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D130493: Disable stack-sizes section by default for PS4.

MaggieYi created this revision. MaggieYi added reviewers: probinson, wristow. Herald added a project: All. MaggieYi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change Clang's default so that -fstack-size-section is no longer

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb09ba4262076: Bug 51277: [DWARF] DW_AT_alignment incorrect when (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11 +} __attribute__((aligned(1))); +struct MyType mt; + dblaikie wrote: > You can drop the "struct" here and from other references to these types (in > mt1/mt2 and the

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi updated this revision to Diff 424420. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.org/D124006 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-struct-align.cpp Index:

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi updated this revision to Diff 424257. MaggieYi added a comment. Thanks David, I have modified the test following your advice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.org/D124006 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi created this revision. MaggieYi added reviewers: echristo, jmorse, wolfgangp, probinson, dblaikie, aprantl. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The detailed description of the