[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

This revision was automatically updated to reflect the committed changes. Closed by commit rG23ef8bf9c0f3: [clangd][CodeComplete] Improve FunctionCanBeCall (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557443. zyounan added a comment. Fix the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557442. zyounan added a comment. Sorry, wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557441. zyounan added a comment. Address nits; discard default template parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files:

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan marked 3 inline comments as done. zyounan added a comment. Thank you guys again for the long and meticulous review! :) For a quick note, here are points I've excerpted from Nathan's reviews that need improvements later: 1. Implement a heuristic that works for function template pointers

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thank you Nathan for your constructive opinions! I've updated this patch again, hopefully this becomes better. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1387 - // When completing a non-static member function (and not via - // dot/arrow

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 556909. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files:

[PATCH] D158926: [clangd] Show parameter hints for operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd6ac6165e6: [clangd] Show parameter hints for operator() (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3577 // containing all of the arguments up to the first deducible argument. + // Or, if this isn't a call, emit all the template arguments + // to disambiguate the (potential)

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan updated this revision to Diff 556358. zyounan marked an inline comment as done. zyounan added a comment. Address a nit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.llvm.org/D158926 Files:

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan marked 2 inline comments as done. zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:626 + Method && Method->isInstance()) +Args = Args.drop_front(1); +processCall(Callee, Args); nridge wrote: > Huh,

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe257c0a91906: [clang][clangd] Ensure the stack bottom before building AST (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 77. zyounan marked an inline comment as done. zyounan added a comment. Remove the stray header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks! I hope I'm getting things right. Specifically, 1. `UpdateIndexCallbacks::indexStdlib()::Task` in `ClangdServer.cpp` 2. `PreambleThread::run()`, `ASTWorker::run()` and `TUScheduler::runWithPreamble()::Task` in `TUScheduler.cpp` 3. The lambda of `runAsync` in

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 555356. zyounan added a comment. Herald added a subscriber: javed.absar. Disperse the call over clangd tasks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd01d75a863: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan marked an inline comment as done. zyounan added a comment. Thanks again for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1 {{no member named 'value' in 'is_convertible'}} + erichkeane wrote: > So I

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 555277. zyounan marked an inline comment as done. zyounan added a comment. Address one last nit comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554919. zyounan added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Thanks for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +// expected-note@* 0+{{}} +// expected-error@* 0+{{}} erichkeane wrote: > Please don't do this, actually

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554914. zyounan marked an inline comment as done. zyounan added a comment. Expand diagnostics in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks again for Richard and Sam's comments! (I didn't add another lit test for asynchronous case since it essentially works the same as the synchronous one. Hope this isn't harmful.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554674. zyounan marked an inline comment as done. zyounan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554285. zyounan added a comment. Oops, something went wrong accidently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. @ilya-biryukov I've updated the patch following your suggestion. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 ___

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554283. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554279. zyounan added a comment. Herald added a project: clang. Adopt the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > According to documentation of noteBottomOfStack, those should be tied to > thread creation, i.e. main and AsyncTaskRunner are two most common entry > points for threads that do parsing. Yeah, I was about to put this call there. But they both boil down to the single

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a subscriber: rsmith. zyounan added a comment. Thanks for the reply. And I understand (and agree with) the point that it's better to solve this problem once and for all. > Currently the code in CompilerInstance::ExecuteAction seems to acknowledge > that there should be a

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > `clang::ParseAST` or `ASTFrontendAction::ExecuteAction` look like good > candidates to me. We had already placed the initialization in ASTFrontendAction::ExecuteAction

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan created this revision. zyounan added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Closes

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551736. zyounan added a comment. Sorry, forgot to update tests :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551730. zyounan added a comment. Fix the bool expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551728. zyounan added a comment. Rebase and Remove the stray status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551726. zyounan added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for Sam and Nathan's thorough review! I've updated, and please take another look. (Apologize for churning on weekends, but I don't have chunk time during the week.) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:258 case

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551723. zyounan marked 14 inline comments as done. zyounan added a comment. Address many comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:9079 +auto *IDC = TC->getImmediatelyDeclaredConstraint(); +assert(IDC && "ImmediatelyDeclaredConstraint can't be null here."); +ExprResult Constraint = SubstExpr(IDC, MLTAL);

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550713. zyounan added a comment. Adapt to D157554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files:

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550683. zyounan added a comment. Rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan created this revision. zyounan added reviewers: saar.raz, erichkeane, ilya-biryukov, aaron.ballman. Herald added a subscriber: kadircet. Herald added a project: All. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 547569. zyounan added a comment. Trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan abandoned this revision. zyounan added a comment. Closing this in favor of D156605 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan updated this revision to Diff 547566. zyounan added a comment. Merge changes with function templates from D155370 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan planned changes to this revision. zyounan added a comment. In D155370#4552967 , @nridge wrote: > I was thinking of functions with different names (with a common prefix) and > different signatures, where the signature could be a useful piece of

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1193c13a5f9: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter (authored by zyounan). Repository: rG LLVM Github Monorepo

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546008. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546007. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. In D155370#4545763 , @nridge wrote: > (e.g. maybe you're looking for one with a particular parameter type). I understand the second point that it'd be nice to offer the user a chance to see the arguments in order to help decide

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Sorry, looks like I messed up with the commits before. Fixed it now. Comment at: clang-tools-extra/clangd/InlayHints.cpp:207 + + // This is a bit tricky: we traverse the type structure and find whether or + // not a type in the desugaring process is

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545922. zyounan added a comment. Fix the chaos in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files:

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545920. zyounan marked 2 inline comments as done. zyounan added a comment. Herald added a project: clang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && zyounan wrote: > The current heuristic results in the following: > > ``` > struct Base { > void foo(int); > }; >

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan created this revision. zyounan added reviewers: sammccall, nridge, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Oops, my apologies for bothering you. Thanks again for the explanation and your dedication! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 544252. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && The current heuristic results in the following: ``` struct Base { void foo(int); }; struct Derived : Base {

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for the insightful suggestions! (Apologies for my late update. Just had a really busy week.) As suggested, I left the CCR intact and handled these functions in `CodeCompletionResult::createCodeCompletionStringForDecl`. I think this preserves the Declaration,

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543280. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543277. zyounan added a comment. Don't change the CCR. Handle these in CreateCodeCompletionString. Emit template arguments if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan created this revision. zyounan added reviewers: nridge, tom-anders, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added a comment. zyounan updated this revision to Diff 540687. zyounan published this revision for review. Herald added

[PATCH] D153724: [clang] Fix a crash on invalid destructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76d72a715038: [clang] Fix a crash on invalid destructor (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534387. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534386. zyounan added a comment. Simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534362. zyounan added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534359. zyounan added a comment. And this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:524 crash when we encounter a unresolved TypoExpr during diagnostic emission. - (`#50244 _`). + (`#50244

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan created this revision. zyounan added reviewers: royjacobson, aaron.ballman, erichkeane, shafik. Herald added a project: All. zyounan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up patch to D126194

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e08374abb2c: [clang][NFC] Add a notice to desugarForDiagnostic (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new/

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

zyounan created this revision. Herald added a project: All. zyounan added reviewers: aaron.ballman, lh123. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. `desugarForDiagnostic` only sets ShouldAKA to true if desugaring happens,

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan added a comment. In D151785#4417973 , @kstoimenov wrote: > Looks like this might have broken a couple of sanitizer builds. Here is one > of them: https://lab.llvm.org/buildbot/#/builders/5/builds/34387. Could you > please revert or fix? >

[PATCH] D152520: [clangd] Unify printing policy for type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cdb906f1e40: [clangd] Unify printing policy for type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan updated this revision to Diff 530867. zyounan added a comment. Rebase onto D151785 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152520/new/ https://reviews.llvm.org/D152520 Files:

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d68f2ef411e: [clangd] Desugar template parameter aliases in type hints (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530851. zyounan added a comment. Oops. Remove extra debugging statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files:

[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

zyounan updated this revision to Diff 530850. zyounan marked an inline comment as done. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files:

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Thank you very much for the insightful review! Regarding to your suggestion, > We have an existing heuristic here, should we move the logic into > maybeDesugar() so it's all in one place? once we merge these two functions, the overloaded `addTypeHint` without a

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan updated this revision to Diff 530201. zyounan marked 7 inline comments as done. zyounan added a comment. Address many comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151785/new/ https://reviews.llvm.org/D151785 Files:

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. (This

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } nridge wrote: > zyounan wrote: > > `PrintCanonicalTypes` turns on

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:267 StructuredBindingPolicy = TypeHintPolicy; StructuredBindingPolicy.PrintCanonicalTypes = true; } `PrintCanonicalTypes` turns on printing default template

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan added a comment. Before F27754400: before.png After F27754403: after.png (Sorry for posting screenshots directly and bringing any inconvenience for email users.) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

zyounan created this revision. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch alleviates

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Thank you for the update. A few questions: - Can you add a test with macro expansion? Would we get two inlay hints right after the spelling location? e.g., #define Decl_Record \ struct Widget { \ [very long definition that reach

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Sorry for chiming in. Left a few nit comments and I hope you don't mind. :) Comment at: clang-tools-extra/clangd/InlayHints.cpp:772 + Label = printName(AST, D); +} else { + // We handle type and namespace decls together.

[PATCH] D148457: [clangd] Support macro evaluation on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG7385cc389aba: [clangd] Support macro evaluation on hover (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520638. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you for the opinions. I've updated and please take a look. Comment at: clang-tools-extra/clangd/Hover.cpp:705 + + // If macro expands to one single token, rule out punctuator or digraph. + // E.g., for the case `array L_BRACKET 42 R_BRACKET;`

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520555. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518280. zyounan added a comment. Exclude the macro expands to single punctulator token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3901 +case 1: + EXPECT_TRUE(HI->Type); + EXPECT_FALSE(HI->Value); Oops, this should be FALSE I think. Repository: rG LLVM

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you very much for the ideas. > (generalization) allow partial selection as long as it's of a single node - > the common ancestor is partially selected and no children are This strategy looks reasonable to me and it passes my test cases. I've updated my patch

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518277. zyounan added a comment. Do not evaluate on partial selection with children. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518144. zyounan added a comment. Refactor tests. Obtain type from VarDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

  1   2   >