[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14742f2a689c: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 528492. ZarkoCA marked an inline comment as done. ZarkoCA removed a reviewer: jsji. ZarkoCA added a comment. Rebase and fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG951919e5112c: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D148960: [Clang][AIX] Add back error for -fprofile-sample-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: qiongsiwu1, w2yehia. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D148177 also removed the error for

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a39465d0015: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D148177: [Clang][AIX] Remove error for -fprofile-instr-generate/use on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: w2yehia, qiongsiwu1, hubert.reinterpretcast. ZarkoCA added a project: PowerPC. Herald added subscribers: wlei, wenlei. Herald added a project: All. ZarkoCA requested review of this revision. Herald added subscribers: cfe-commits, MaskRay.

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

This revision was automatically updated to reflect the committed changes. Closed by commit rGa61b202d4e3b: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 443812. ZarkoCA added a comment. - Rebase and add FDecl check before calling checkAIXMemberAlignment() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5255 + const auto *PVD = dyn_cast( + (dyn_cast( + (dyn_cast(Arg->IgnoreParens()))->getSubExpr())) sfertile wrote: > I find these

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 413818. ZarkoCA added a comment. - Restructured checks - fixed comment - removed unnecessary parameter passed to function - slightly reworded summary of patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5246 + + if (const auto *ICE = dyn_cast(Arg->IgnoreParens())) { +if (const auto *DR = dyn_cast(ICE->getSubExpr())) { sfertile wrote: > Nit: To avoid the deep nesting, can we instead

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412840. ZarkoCA added a comment. - Remove formatting changes to unrelated code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 412826. ZarkoCA added a comment. - Try to remove deeply nested ifs by using early returns - Fix note so it refers to struct - Add a struct that isn't called byval in test case to make it clearer that warning isn't emitted on every declaration Repository:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 411912. ZarkoCA retitled this revision from "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function" to "[Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function".

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. After offline discussion with @sfertile , the warning should occur only when the struct member is passed on the stack. I will be updating the patch shortly. @aaron.ballman Thank you for the thorough reviews comments and sorry for the churn. Repository: rG LLVM

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3299-3301 +: Warning<" %0 byte requested alignment for a struct member used as an" + " argument is 16 bytes or greater which is not binary" + " compatible

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406843. ZarkoCA added a comment. - Shorten warning message - Add new note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/test/Sema/aix-attr-align.c:34-35 + baz(s.a); // no-warning + baz(s.b); // expected-warning {{requesting an alignment of 16 bytes or greater for struct members is not binary compatible with IBM XL C/C++ for AIX 16.1.0 and

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406822. ZarkoCA added a comment. - Warn on declaration of struct member and add note for call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA marked 4 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5220-5221 + Context.toCharUnitsFromBits(AA->getAlignment(Context)); + if (Alignment.getQuantity() >= 16) +Diag(Loc,

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406620. ZarkoCA added a comment. - Add note for diagnostic pointing to declaration of the struct member - cleaned up use of unneeded variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 406086. ZarkoCA added a comment. - Moved AIX check to its own function to hopefully avoid Arg and ArgTy getting out of sync - Rebased and removed LIT test cases workaround Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

ZarkoCA added inline comments. Comment at: clang/test/SemaTemplate/instantiate-attr.cpp:1 // RUN: %clang_cc1 -fsyntax-only -verify %s // expected-no-diagnostics hubert.reinterpretcast wrote: > Add `-Wno-aix-compat` instead? I agree with this, this way AIX

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added a comment. In D118350#3282855 , @nemanjai wrote: > Would it make sense (and would it be possible) to check the linkage of the > callee? Presumably calling something like > `static void localfunc(int *)` > with an over-aligned member

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404600. ZarkoCA added a comment. - Warning shouldn't apply to functions that have internal linkage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118350 Files:

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); +

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404190. ZarkoCA added a comment. Addressed some of the comments: - Applied code cleanup per suggestions - Used `CharUnits` instead of hard coded values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404090. ZarkoCA added a comment. Addressing comments: - Change comment before checkArgAlignment() - Add missing RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 403857. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Fixed formatting - Fixed test case - Check for when Arg is nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D118350: [AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA created this revision. ZarkoCA added reviewers: hubert.reinterpretcast, sfertile, cebowleratibm, stevewan, Jake-Egan, aaron.ballman, tmatheson, dnsampaio. ZarkoCA added projects: clang, PowerPC. Herald added subscribers: shchenz, nemanjai. ZarkoCA requested review of this revision. Herald

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3162140 , @rjmccall wrote: > Those all look good, thanks. Committed here Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ad6fa279cc: [clang][docs] Inclusive language: remove use of sanity check in option… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall These are the proposed changes which address some of your comments. I am planning on waiting for further clarification on some of the others. Comment at: clang/include/clang/Analysis/CFG.h:520 /// to keep receiving compiler warnings

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5162b558d8c0: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA updated this revision to Diff 389737. ZarkoCA added a comment. - Fix description - Remove `three` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114562/new/ https://reviews.llvm.org/D114562 Files: clang/docs/ThreadSafetyAnalysis.rst

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. @rjmccall thanks for having a look, I will clarify the comments with your suggestions. In D114025#3152900 , @tstellar wrote: > @ZarkoCA If you are planning to do a lot of this, it might be good to write a > script (or a

[PATCH] D114562: [clang][docs] Inclusive language: remove use of sanity check in option description

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, delesley, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114562 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e5a0c42bd8: [clang][NFC] Inclusive terms: replace some uses of sanity in clang (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D114025?vs=388550=388587#toc Repository: rG

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Thanks @aaron.ballman and @Quuxplusone for the constructive reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9176 // Don't check the implicit member of the anonymous union type. - // This is technically non-conformant, but sanity demands it. + // This is technically non-conformant, but validation

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388550. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. - Address latest round of comments - Fix unrelated formatting to stop distracting clang-format linter complaints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388494. ZarkoCA added a comment. - Add FIXME to comments and fix grammar on one comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. In D114025#3142565 , @aaron.ballman wrote: > In D114025#3141414 , @keryell wrote: > >> In D114025#3140192

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA marked 13 inline comments as done. ZarkoCA added a comment. @Quuxplusone Thanks for thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388332. ZarkoCA added a comment. - Address review comments - Also rename some variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025 Files:

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140192 , @Quuxplusone wrote: > Peanut gallery says: I'd recommend //not// taking this particular patch; it > seems much less "obvious" than the whitelist/inclusionlist type of patch. > Whereas "whitelist" is just a

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA updated this revision to Diff 388207. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. - Reword comments based on suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114025/new/ https://reviews.llvm.org/D114025

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA added a comment. In D114025#3140161 , @martong wrote: > Do we have a comprehensive list of non-inclusive terms and their inclusive > correspondent somewhere available? > I mean `master` -> `main`, `white list` -> `inclusive list`, `sanity` -> >

[PATCH] D113505: [NFC][clang] Inclusive language: replace masterPort with mainPort

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113505/new/ https://reviews.llvm.org/D113505

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

This revision was automatically updated to reflect the committed changes. Closed by commit rG8924ba3bf8c6: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/ (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

ZarkoCA created this revision. ZarkoCA added reviewers: klimek, akyrtzi, quinnp. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits. Herald added a project: LLDB. Rename function to more inclusive name. Repository: rG

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

ZarkoCA created this revision. ZarkoCA added reviewers: aaron.ballman, dcoughlin, quinnp. ZarkoCA added a project: clang. Herald added subscribers: dexonsmith, martong. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Rewording of comments to avoid using `sanity

[PATCH] D113433: [NFC][clang] Inclusive language: Rename myMaster in testcase

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113433/new/ https://reviews.llvm.org/D113433

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

This revision was automatically updated to reflect the committed changes. Closed by commit rG05f34ffa2169: [clang] Inclusive language: change instances of blacklist/whitelist to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385479. ZarkoCA added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113189/new/ https://reviews.llvm.org/D113189 Files: clang/include/clang/AST/CommentHTMLTags.td

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA updated this revision to Diff 385478. ZarkoCA retitled this revision from "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist " to "[clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist". ZarkoCA added a

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7528554f83: [AIX][Clang] Fix XL product name in AIX XL compatibility warning (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

This revision was automatically updated to reflect the committed changes. Closed by commit rGa83a6c22e63a: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path=arg… (authored by ZarkoCA). Changed prior to commit: https://reviews.llvm.org/D112591?vs=383507=385099#toc

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

ZarkoCA added a comment. In D113211#3110171 , @jkorous wrote: > Hi! Thank you for the clean-up :) > > I feel there might be a bit of work still left. While renaming filenames and > function names should be mostly inconsequential renaming command line

[PATCH] D113211: [NFC][clang] Inclusive terms: replace uses of blacklist in clang/test/

ZarkoCA created this revision. ZarkoCA added reviewers: kcc, samsonov, jkorous, lebedev.ri, pcc, vlad.tsyrklevich. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace filenames, variable names, check prefixes uses of blacklist

[PATCH] D113189: [clang] Inclusive language: change instances of blacklist/whitelist to allowlist/ignorelist

ZarkoCA created this revision. ZarkoCA added reviewers: thakis, compnerd, rtrieu, gribozavr, kcc. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change the error message to use ignorelist, and changed some variable and function

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383805. ZarkoCA added a comment. - Remove comma from product name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files:

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA updated this revision to Diff 383804. ZarkoCA added a comment. - Remove V from version number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112847/new/ https://reviews.llvm.org/D112847 Files:

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA updated this revision to Diff 383507. ZarkoCA added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112591/new/ https://reviews.llvm.org/D112591 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D112847: [AIX][Clang] Fix XL product name in AIX XL compatibility warning

ZarkoCA created this revision. ZarkoCA added reviewers: rzurob, cebowleratibm, sfertile. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Correct the XLC/C++ version in the warning message to use the information from XL's -qversion

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8659b241ae94: [clang][NFC] Inclusive terms: Replace uses of whitelist in… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA marked 6 inline comments as done. ZarkoCA added a comment. In D112642#3093559 , @aaron.ballman wrote: > Thank you for this! Mostly just bikeshedding on names (allowlist as a verb > sounds weird to me), feel free to take or leave the

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA updated this revision to Diff 383359. ZarkoCA added a comment. - Fix formatting and change variable names to make better grammatical sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112642/new/ https://reviews.llvm.org/D112642 Files:

[PATCH] D112642: [clang][NFC] Inclusive terms: Replace uses of whitelist in clang/lib/StaticAnalyzer

ZarkoCA created this revision. ZarkoCA added reviewers: zaks.anna, jkorous, george.karpenkov, ygribov, Szelethus, quinnp, aaron.ballman. ZarkoCA added a project: clang. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, a.sidorin, baloghadamsoftware. ZarkoCA requested

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA added a comment. In D112591#3090710 , @akyrtzi wrote: > Do you intend to rename `clang/test/ARCMT/whitelisted` directory as a > follow-up? Otherwise LGTM. Missed this initially, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA updated this revision to Diff 382708. ZarkoCA added a comment. - Rename directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112591/new/ https://reviews.llvm.org/D112591 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

ZarkoCA created this revision. ZarkoCA added reviewers: tuktuk, vitalybuka, MaskRay. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112627 Files:

[PATCH] D112591: [clang] [Objective C] Inclusive language: use objcmt-allowlist-dir-path= instead of objcmt-white-list-dir-path=

ZarkoCA created this revision. ZarkoCA added reviewers: akyrtzi, rsmith, quinnp. ZarkoCA added a project: clang. Herald added a subscriber: dang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Trying to update some options that don't at least have an inclusive

[PATCH] D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/lib/Headers/altivec.h:3178 + : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) * \ + (vector float)(vector unsigned)((0x7f - (__b)) << 23 & 0x1F)),

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 376630. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Herald added a subscriber: steven.zhang. - Only truncate **b** and not result - Add a proper test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106409/new/ https://reviews.llvm.org/D106409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b0a71c5fc05: [PowerPC][AIX] Add support for varargs for complex types on AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added a comment. In D106393#3000122 , @sfertile wrote: > I suggest we separate the clang change and testing into a standalone patch, > and the llvm backend tests into a standalone patch which we can commit > separately. LLVM tests added in

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 372736. ZarkoCA added a comment. - Removed llc tests - Added a helper function to combine the PPC64_SVR4ABI and AIXABI treatment of complex types less than register size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109078/new/ https://reviews.llvm.org/D109078

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + ZarkoCA wrote: > sfertile wrote: > > The

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/test/CodeGen/aix32-complex-varargs.c:2 +// REQUIRES: powerpc-registered-target +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -emit-llvm -o - %s | FileCheck %s + sfertile wrote: > The code-gen for int and

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:31 +// CHECK-INTERNAL-INCLUDE: "-isysroot" "[[SYSROOT:[^"]+]]" +// CHECK-INTERNAL-INCLUDE-CXX: "-internal-isystem" "[[SYSROOT]]/opt/IBM/openxlCSDK/include/c++/v1" +//

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +addSystemInclude(DriverArgs, CC1Args, PathCPP.str()); +CC1Args.push_back("-D__LIBC_NO_CPP_MATH_OVERLOADS__"); +return; Maybe a comment as to why we need this,

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 369112. ZarkoCA added a comment. Rebase to ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D106409: [PowerPC] Truncate results for out of range values for vec_cts,vec_ctf

ZarkoCA updated this revision to Diff 367525. ZarkoCA retitled this revision from "[PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf" to "[PowerPC] Truncate results for out of range values for vec_cts,vec_ctf". ZarkoCA edited the summary of this revision. ZarkoCA added a

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

ZarkoCA accepted this revision. ZarkoCA added a comment. LGTM also. Just a comment typo. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1779 + // On AIX, zero-width bitfields pad out to the natural alignment boundary, + // but dont increase the alignment greater than the

[PATCH] D107105: [AIX] Pass the -b option to linker on AIX (with fix to build break)

ZarkoCA added a comment. Thanks for the quick turn around and fix @anjankgk, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107105/new/ https://reviews.llvm.org/D107105 ___ cfe-commits mailing list

[PATCH] D107063: Set TargetCPUName for AIX to default to pwr7.

ZarkoCA added a comment. Thanks @jamieschmeiser this change LGTM but I'll defer to @hubert.reinterpretcast for final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107063/new/ https://reviews.llvm.org/D107063

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:263 + if (!T.isOSAIX()) { +TC.getDriver().Diag(diag::err_drv_unsupported_opt) +<< A.getAsString(Args); anjankgk wrote: > ZarkoCA wrote: > > nit, I

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM with small nit, thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:263 + if (!T.isOSAIX()) { +

[PATCH] D106688: [AIX] Pass the -b option to linker on AIX

ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:262-269 + if (T.isOSAIX()) { +// Pass -b prefix for AIX linker. +A.claim(); +A.render(Args, CmdArgs); +continue; + } else { +

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4577-4583 + // If we have a complex type and the base type is smaller than 8 bytes, + // the ABI calls for the real and imaginary parts to be right-adjusted + // in separate doublewords. However,

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 360535. ZarkoCA added a comment. - Fix comment to also describe what happens in 32bit mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files:

[PATCH] D106409: [PowerPC] Add diagnostic for out of range values for vec_cts,vec_ctf

ZarkoCA created this revision. ZarkoCA added reviewers: bmahjour, nemanjai, jsji, PowerPC. Herald added subscribers: shchenz, kbarton. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM (llc) will crash when a user specifies a

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile, PowerPC. Herald added subscribers: shchenz, kbarton, nemanjai. ZarkoCA requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Remove the previous

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66225db98d83: [PowerPC][AIX] Add warning when alignment is incompatible with XL (authored by ZarkoCA). Repository: rG LLVM Github Monorepo

  1   2   3   >