[PATCH] D86034: [WIP] Attribute harden_misspeculation

zbrid created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid requested review of this revision. Starting with if support first - Parse attribute check for diagnosable issues with its usage Repository: rG LLVM

[PATCH] D86033: This is mostly prototype code that should be deleted.

zbrid created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid requested review of this revision. Revert or squash this before uploading for review. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86033 Files: clang/lib/Sema/SemaStmt

[PATCH] D85039: [DO NOT SUBMIT][WIP] prototype

zbrid created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, hiraditya. Herald added projects: clang, Sanitizers, LLVM. zbrid requested review of this revision. Not intended to be reviewed. I only uploaded this patch to have a link to share. Repository: rG LLVM

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Herald added a subscriber: jfb. Changed prior to commit: https://reviews.llvm.org/D79910?vs=272117&id=275687#toc R

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://revi

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276196. zbrid added a comment. rebase prior to commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst clang/include/cl

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276153. zbrid added a comment. Herald added a subscriber: jfb. update seses flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineRefer

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276147. zbrid added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Driver/Optio

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added a comment. @sconstab @craig.topper - Ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption, DriverOptio

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272117. zbrid added a comment. Fix accidentally deleted clang command line ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReferen

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added a comment. @sconstab @craig.topper @mattdr -- This is ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___ cfe-com

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272114. zbrid added a comment. seses implies lvi-cfi also enable-seses -> enable-seses-without-lvi-cfi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/doc

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90 + const X86Subtarget &Subtarget = MF.getSubtarget(); + if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() && + !EnableSpeculativeExecutionSideEffect

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 272105. zbrid marked an inline comment as done. zbrid added a comment. Update Clang Command Ref with automated tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid marked 2 inline comments as done. zbrid added a comment. Thanks for the ping, Scott. I'll update this so I can get it submitted soon. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lv

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

This revision was automatically updated to reflect the committed changes. Closed by commit rG60ee88599098: [clang][asm goto][slh] Warn if asm goto + SLH (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.ll

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 265282. zbrid added a comment. ClangFormat diagnostic definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: clang/include/clang/Basic/DiagnosticCommonKinds.

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. In D79743#2044676 , @jyu2 wrote: > This looks good to me. Could you also add a test to use this new DiagGroup > (-Wno-slh-asm-goto)? > > Thanks. > > Jennifer Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 265081. zbrid added a comment. Add test; Update command for existing test Also rename file to match warning flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files:

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 264740. zbrid marked an inline comment as done. zbrid added a comment. Update to emit the warning in the parser Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: c

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. @jyu2 and @mattdr - updated to address your comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 ___ cfe-commits mailing list cfe-co

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid marked 3 inline comments as done. zbrid added a comment. > Do you mean runtime crash? If so, I think error should be emit, so that > programmer can remove use of "asm goto" and recompile. This would be a compile time crash. At some point the X86SpeculativeLoadHardening pass in the backend

[PATCH] D79894: [clang][slh] Add test for SLH feature checking macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG18a855da431e: [clang][slh] Add test for SLH feature checking macro (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79894/new/ https://rev

[PATCH] D79910: [WIP][seses] Add clang flag; Use lvi-cfi with seses

zbrid created this revision. zbrid added reviewers: sconstab, craig.topper, mattdr. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch creates a clang flag to enable SESES. This flag also ensures that lvi-cfi is on when using seses via cl

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid added a comment. In D79743#2034792 , @jyu2 wrote: > Two questions: > 1> What happen under SLH, will asm goto gets removed, or a runtime problem? > 2> Should we emit error or warning in the Parser instead? 1. SLH crashes with an unhelpful er

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid updated this revision to Diff 263819. zbrid added a comment. Update to fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79743/new/ https://reviews.llvm.org/D79743 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td cl

[PATCH] D79894: [clang][slh] Add test for SLH feature checking macro

zbrid created this revision. zbrid added reviewers: craig.topper, mattdr. Herald added a project: clang. Herald added a subscriber: cfe-commits. I forgot to include a test in this commit: https://reviews.llvm.org/rG379e68a763097bed6c6dc7453e4b732e3d68 Here's the test. It passes after that com

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

This revision was automatically updated to reflect the committed changes. Closed by commit rG379e68a76309: [clang][SLH] Add __has_feature(speculative_load_hardening) (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79733/new/ https

[PATCH] D79743: [clang][asm goto][slh] Warn if asm goto + SLH

zbrid created this revision. zbrid added reviewers: mattdr, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Asm goto is not supported by SLH. Warn if an instance of asm goto is detected while SLH is enabled. Test included. Repository: rG LLVM Github Monorepo ht

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid updated this revision to Diff 263247. zbrid added a comment. Change langopt type + SpeculativeLoadHardeningEnabled -> SpeculativeLoadHardening This is to match the CodeGenOpt for SLH that already exists and to address mattdr's feedback. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if (Args.hasFla

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if (Args.hasFla

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid created this revision. zbrid added reviewers: craig.topper, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid marked an inline comment as done. zbrid added inline comments. zbrid marked an inline comment as done. Comment at: clang/lib/Dr

[PATCH] D78953: [libcxx][docs][dfsan] Fix rst rendering related typos

This revision was automatically updated to reflect the committed changes. Closed by commit rGc750847e0c3b: [libcxx][docs][dfsan] Fix rst rendering related typos (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78953/new/ https://re

[PATCH] D78953: [libcxx][docs][dfsan] Fix rst rendering related typos

zbrid created this revision. zbrid added reviewers: ldionne, EricWF. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. - Fix the code block disappearance problem by adding a new line - Fix the typo where I forgot a space Repository: rG LLVM Github Monorepo http

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f12480bd13a: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://revi

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Bug: https://bugs.llvm.org/show_bug.cgi?id=45621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 ___ cfe-commits mailing list cfe-commits

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258789. zbrid added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst libcxx/CMakeLists.txt libcxx/utils/lib

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Gonna land this and file a bug for the failing tests. The tests shouldn't block anyone upstream since I'm only adding a build mode. I'll do some more digging into those failures in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258608. zbrid added a comment. - Remove dfsan feature based on review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258462. zbrid added a comment. Update nit from Matt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst libcxx/CMakeLists.txt li

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: libcxx/utils/libcxx/test/config.py:914 +self.cxx.flags += ['-fsanitize=dataflow'] +self.config.available_features.add('dfsan') else: broa

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258447. zbrid added a comment. Update documentation based on Matt's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Files: clang/docs/DataFlowSanitizer.rst

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid updated this revision to Diff 258383. zbrid added a comment. Herald added a subscriber: broadwaylamb. Update config.py to support data flow sanitizer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 Fi

[PATCH] D78390: [dfsan] Add "DataFlow" option to LLVM_USE_SANITIZER

zbrid added a comment. Oh I found some lit tests that fail by running `check-cxx`. I'll address that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78390/new/ https://reviews.llvm.org/D78390 ___ cfe-co

[PATCH] D78390: [dfsan] Add dataflow option to LLVM_USE_SANITIZER

zbrid created this revision. zbrid added a reviewer: morehouse. Herald added subscribers: libcxx-commits, cfe-commits, mgorny. Herald added projects: clang, libc++. Herald added a reviewer: libc++. zbrid added a reviewer: EricWF. zbrid edited the summary of this revision. This patch add the datafl

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

zbrid accepted this revision. zbrid added a subscriber: jyknight. zbrid added a comment. This revision is now accepted and ready to land. LGTM. I would prefer if an actual LLVM maintainer also gave LGTM. @jyknight, @george.burgess.iv, @craig.topper? CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D76458: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [by modifying X86RetpolineThunks.cpp]

zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature< + "lvi-cfi", "UseLVIControlFlowIntegrity", "true", + "Prevent indirect calls/branches from using a memory operand, and " Also to follow up on the di

[PATCH] D76458: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [by modifying X86RetpolineThunks.cpp]

zbrid added a comment. I commented on the other patch about this before I saw this patch. Thanks for putting this up! I think it looks pretty good, but could you do a more full refactor of the retpolinethunks pass in an NFC patch? Then have the LVI functionality added on top of that refactored

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

zbrid added a comment. I followed up with Chandler about whether it would make sense to integrate this with the existing retpolines pass as you and Craig suggested. He supported the idea. Could you create a new patch(es) to do the refactor/renaming of the retpolines thunking pass and instructio

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

zbrid added a comment. Thanks for putting this up! Here are a few comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:1 +//==-- ImmutableGraph.h - A fast DAG implementation -=// +// Might be useful if you add a comment about what

[PATCH] D75934: Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [2/6]

zbrid added a comment. Looks great! Thanks for writing this! I had a bunch of nits (sorry!) and a few questions, otherwise LGTM. Please wait for sign off from at least one other person before submitting. Comment at: llvm/lib/Target/X86/X86FastISel.cpp:3210 // Functions u

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192873. zbrid marked an inline comment as done. zbrid added a comment. actually fix if statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/cl

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp:614-628 + if (Opcode == X86::SpeculationSafeValue32) { +BuildMI(MBB, NMBBI, DebugLoc(), TII->get(X86::LFENCE)); +++NumInstsIns

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192870. zbrid added a comment. remove unnecessary if in x86 slh intrinsic lowering function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/B

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192857. zbrid added a comment. remove unnecessary requirement from builtin test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/Basic/Builtin

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192852. zbrid added a comment. fix test formatting; make target independent intrinsic; add doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clan

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192845. zbrid added a comment. update with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files: clang/include/clang/Basic/Builtins.def clang/include/cl

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192297. zbrid added a comment. Herald added a subscriber: jsji. update whitespace in wasm file to match surrounding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827 Files:

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid created this revision. zbrid added reviewers: chandlerc, kristof.beyls, aaron.ballman, devinj.jeanpierre. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jfb, aheejin, hiraditya, javed.absar, dschuff. Herald added projects: clang, LLVM. This is similar to the work Kristof d

[PATCH] D54909: [clang][slh] add Clang attr no_speculative_load_hardening

This revision was automatically updated to reflect the committed changes. Closed by commit rC351565: [clang][slh] add Clang attr no_speculative_load_hardening (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54909?vs=

[PATCH] D54555: [clang][slh] add attribute for speculative load hardening

This revision was automatically updated to reflect the committed changes. Closed by commit rC347586: [clang][slh] add attribute for speculative load hardening (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54555?vs=

[PATCH] D54763: [clang][slh] Forward mSLH only to Clang CC1

This revision was automatically updated to reflect the committed changes. Closed by commit rC347582: [clang][slh] Forward mSLH only to Clang CC1 (authored by zbrid, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D54763?vs=174813&id=1752