[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG903e530bb898: [clang] Add cleanup_function field to CleanupAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo

[PATCH] D157783: [clang] Add rmissing fields to DeprecatedAttr and UnavailableAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dadc290b210: [clang] Add missing fields to DeprecatedAttr and Unavailable json AST dump (authored by serge-sans-paille). Repository: rG LLVM Gith

[PATCH] D157795: [clang] Add missing field to SectionAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf7666b8f09: [clang] Add missing field to SectionAttr json AST dump (authored by serge-sans-paille). Changed prior to commit: https://reviews.llv

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2107d87c5a91: [clang] Add missing field to VisibilityAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2105c32b32bf: [clang] Add missing field to TLSModelAttr json AST dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a side effect, introduce AtomicExpr::getOpAsString

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. I don't have a strong opinion on the synchronization with `TextNodeDumper`. I'm pretty sure I didn't update it while adding fields for the Attribute nodes though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbccf3c6f13d: [clang] - Add missing builtin name to AtomicExpr JSON dump (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHA

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545060. serge-sans-paille added a comment. Take reviewers comment into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545074. serge-sans-paille added a comment. (rebased on `main`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

serge-sans-paille added a comment. In D158558#4616275 , @efocht wrote: > Can somebody please revert this patch? It kills all builds on > https://lab.llvm.org/buildbot/#/builders/91 since yesterday. > @serge-sans-paille ? This got reverted by https://r

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

serge-sans-paille added a comment. Jumping a bit late in the thread, apologize in advance if I missed something. The GCC version of the attributes seems to be `element_count` (as found in the link https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 mentionned by @kees) I guess we could align (I

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:966 +// size. e.g.(("%#3x", 0xf) is "0xf") + +// If the result is zero, o, b, x, X adds nothing. Then couldn't we increase the Size if the `FieldWidth` is unspeci

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille added a comment. In D156337#4558410 , @aaron.ballman wrote: > Was there an RFC for this extension to the attribute? (There doesn't need to > be one, I'm just wondering if there's more background info on what's driving > this patch for

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

serge-sans-paille added inline comments. Comment at: clang/docs/ReleaseNotes.rst:125 * ``-Woverriding-t-option`` is renamed to ``-Woverriding-option``. * ``-Winterrupt-service-routine`` is renamed to ``-Wexcessive-regsave`` as a generalization ?? =

[PATCH] D118532: Fix -Wreserved-identifier in presence of system macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8290ffa9fd9: Fix -Wreserved-identifier in presence of system macro (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, lenary, mehdi_amini, MaskRay. Herald added subscribers: jeroen.dobbelaere, ormris, foad, dexonsmith, wenlei, jdoerfert, kerbowa, pengfei, arphaman, steven_wu, hiraditya, nhaehnle, jvesely, arsenm. Herald added a

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. Hi and thanks for taking the time to go through the review. In D118652#3285601 , @MaskRay wrote: > Thanks for working on this. I spot checked some files. In general it looks > great. > > One file replaces a forward dec

[PATCH] D118652: Cleanup header dependencies in LLVMCore

serge-sans-paille added a comment. In D118652#3286018 , @mehdi_amini wrote: > I'm not sure how it'd help clients of the released version of LLVM to delay, > the development branch and the release seems fairly disconnected to me from > this point of vie

[PATCH] D118652: Cleanup header dependencies in LLVMCore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe188aae406f3: Cleanup header dependencies in LLVMCore (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118608: [NFC] Increase initial size of FoldingSets used in ASTContext and CodeGenTypes

serge-sans-paille added a comment. Thanks, that's helpful. Any hint about why this particular values? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118608/new/ https://reviews.llvm.org/D118608 ___ cfe-co

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, mehdi_amini, lenary. Herald added subscribers: awarzynski, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, foad, dcaballe, cota, teijeong, frasercrmck, dexonsmith, rdzhabarov, tatianashp, msifontes, jurahul,

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. @rsmith : once the licensing issue has been fixed, can we merge that patch or do you have any other thought? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 ___ cf

[PATCH] D60380: Also document -arch as -arch is mac specific

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Thanks o/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 __

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

serge-sans-paille added a comment. In D118781#3291801 , @MaskRay wrote: > $ clang++ -E -Iinclude -I../llvm/include > ../llvm/lib/Transforms/Scalar/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc > -l > before: 10978519 > after: 11245451 > > The nu

[PATCH] D118781: Reduce dependencies on llvm/BinaryFormat/Dwarf.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffe8720aa060: Reduce dependencies on llvm/BinaryFormat/Dwarf.h (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille updated this revision to Diff 374290. serge-sans-paille added a comment. Set default as suggested by @nickdesaulniers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/lib/

[PATCH] D109693: Driver: Remove major release version detection for RHEL

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, please reformat the code though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109693/new/ https://reviews.llvm.org/

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sylvestre.ledru. Herald added a subscriber: whisperity. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://bugs.llvm.org/show_bug.cgi?id

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe45f67f31e22: Make analyze-cc path discovery sensible to symlinks (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D109967: Simplify handling of builtin with inline redefinition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6f49a56995: Simplify handling of builtin with inline redefinition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kees great, thanks for confirming - I just landed the patch. Can you share a pointer to the missing pieces? I'm interested in implemented the missing parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/ne

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. for the record: I had to apply that extra patch: bd379915de38a9af3d65e19075a6a64ebbb8d6db which enforces the `always_inline` attribute Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @kda : thanks for the builbot reference. The issue you're pointing at occurs *before* bd379915de38a9af3d65e19075a6a64ebbb8d6db which specifically fixes the issue spotted by the buildbot. A

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis if rG1ecb1bc3e214 doesn't work, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D1099

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis: fine on OSX: http://45.33.8.238/macm1/18808/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___ cfe-com

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. And on Windows: http://45.33.8.238/win/46077/summary.html ! Thanks for pointing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 _

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille created this revision. serge-sans-paille added reviewers: kees, nickdesaulniers. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per the GCC info page: If the function is declared 'extern', then this d

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376790. serge-sans-paille added a comment. + extra test case + avoid Playing with Twines + fix storage of external declaration of inline builtins + minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.o

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376794. serge-sans-paille added a comment. + fix linkage of generated function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 Files: clang/lib/AST/Decl.cpp clang/lib/CodeGen/CGExpr.cpp cla

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

serge-sans-paille updated this revision to Diff 376812. serge-sans-paille added a comment. + extra test case + use internal linkage instead of available_externally linkage for generated clone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009 Fi

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0e31cf511d: Update inline builtin handling to honor gnu inline attribute (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D111009?vs=376812&id=377023#toc Repository:

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. In D109967#3044464 , @rnk wrote: > Thanks for doing this, this approach looks like it incorporated my feedback > on the previous approach. Yeah, listened to the wise men... and struggled a lot doing so ;-) =

[PATCH] D112914: Misleading identifier detection

serge-sans-paille updated this revision to Diff 384381. serge-sans-paille added a comment. Fix comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/mi

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille added a comment. In D112916#3102767 , @serge-sans-paille wrote: > @tonic / @tstellar as members of the LLVM fundation board, can you tell us if > it's okay to ship the `confusables.txt` file from > https://www.unicode.org/Public/secur

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MisleadingBidirectional.cpp:59 +// If conversion fails, utf-8 is designed so that we can just try next char. +if (Result != llvm::conversionOK) { + ++CurPtr; rsmi

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384687. serge-sans-paille added a comment. - Add documentation and changelog entry - Formatting / renaming nits - Some extra test cases - Check scope intersection in both orders CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ htt

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384694. serge-sans-paille added a comment. Update doc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 384854. serge-sans-paille added a comment. Portable `confusable.txt` parsing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tool

[PATCH] D112914: Misleading identifier detection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG299aa4dfa1d8: Misleading unicode identifier detection pass (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D112

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. Yep, I'm currently validating locally, I somehow messed up a rebase :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914 ___ c

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3119704 , @thakis wrote: > The test seems to trigger an assert: http://45.33.8.238/linux/60293/step_9.txt > > Please take a look! It's getting late here: Reverted, I'll have a look tomorrow. Repository: r

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-misleading-identifier.cpp:3 + +#include + RKSimon wrote: > @serge-sans-paille Any chance you can remove the include and just forward > declare printf()? Sure,

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This is a WIP, to start the discussion. I've only turned on the X86 backend. Otherwise should be functional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/ https://reviews.llvm.org/D114082 ___

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388424. serge-sans-paille added a comment. Rebase on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clan

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Patch rebased on main, all comments addressed. Looks good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille updated this revision to Diff 388425. serge-sans-paille added a comment. Nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/MiscT

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

serge-sans-paille added subscribers: rsmith, serge-sans-paille. serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114229/new/ https://reviews.llvm.org/D114229 _

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille created this revision. serge-sans-paille added reviewers: dblaikie, nikic. Herald added subscribers: ormris, dexonsmith, wenlei, okura, jdoerfert, kuter, haicheng, hiraditya, eraman. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald a

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This diff is indeed very large. I reworked it in https://reviews.llvm.org/D114394 to capture the essence of it, on which we could then rebase this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389187. serge-sans-paille added a comment. Remove static Dict and replace it by a dict attached to LLVMContext. Some early benchmarks, on the SQLite amalgamation, through ` valgrind --tool=callgrind ./bin/clang -c -o/dev/null sqlite3.c` Instructio

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389437. serge-sans-paille marked 6 inline comments as done. serge-sans-paille added a comment. Use CachedHashStringRef as suggested by @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 Fil

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389463. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CodeGenFunction.cpp llvm/include/llvm/Ana

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:79 + bool operator<(AttributeKey const &other) const { +return strcmp(value_, other.value_) < 0; + } JonChesterfield w

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. In D114082#3149631 , @rnk wrote: >> it is possible to list all internal keys in one place > > I think one of the original goals of adding support for string attributes > (maybe @void will give some input) was specifical

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. > Frontends not written in C++ will always be going through the > AttributeKey::get() API, which will be slower than the initial state (I think > -- we still have to calculate the hash dynamically, but now we also need to > intern an AttributeKey by performing

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. *comment removed, I've been doing more detailed benchmark that imply a rework of the patch* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___ cfe-commits mailing

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 393058. serge-sans-paille added a comment. Use a DenseSet instead of a DenseMap to store the StringPool. Some benchmark feedback (using a release build compiled with LTO), in number of instructions | | sqlite3.c -c -O0 | sqlite3.c -S

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, dblaikie, rnk. Herald added subscribers: dexonsmith, jdoerfert, mgrang, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille added a comment. Update: the strategy used by ``AttrBuilder`` might not be the best way to build new attributes. I've proposed an alternative implementation in https://reviews.llvm.org/D115798. This is somehow orthogonal to that patch, but it removes the need for temporary cop

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added a comment. My plan mid-term plan would be to rename `AttrBuilder` into `AttrQuery` at some point, and use `SmallAttrBuilder` as the actual `AttrBuilder` in most places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/ne

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille updated this revision to Diff 394542. serge-sans-paille added a comment. Leverage the fact that AttributeSet nodes are already sorted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.llvm.org/D115798 Files: clang/include/clang/CodeGen/CodeGe

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added a comment. Actual benchmarks: https://llvm-compile-time-tracker.com/compare.php?from=7d97678df7f514c14b7611447dad02e9cc5168c9&to=f39a39e09e8f4f3b7dc94e4d23d9acfbf36ab2e5&stat=instructions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115798/new/ https://reviews.

[PATCH] D115798: Provide SmallAttrBuilder as a lightweight alternative to AttrBuilder

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:974 + SmallVector EnumAttrs; + SmallVector StringAttrs; + using iterator = typename SmallVector::iterator; nikic wrote: > Just wondering if storing both in one vector would

[PATCH] D120205: Restore documentation for __builtin_assume

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, vdelvecc. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This got removed by 6cacd420a1d72bca7809e6b516fb1e18ac6056c8

[PATCH] D120205: Restore documentation for __builtin_assume

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79c9072dc009: Restore documentation for __builtin_assume (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

serge-sans-paille added a comment. I don't object to the change but it may me wonder if there would be a way to remove the apparent redundancy in the API here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

serge-sans-paille added a comment. A small local test hints that using a ``SmallVector`` instead of a ``std::vector`` also fixes the assembly bloat. I don't know if it's worth considering as an alternative or as an extra step. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120334: [NFC][Lexer] Use more appropriate LangOptionsBase type for Lexer::LangOpts

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=79c9072dc009693477242bc1347a2a6c3e419423&to=702bdad5179ebb90c8d8a16c800ffd1b3c44744d&stat=instructions << indeed a lot of green there! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D112916: Confusable identifiers detection

serge-sans-paille updated this revision to Diff 410776. serge-sans-paille added a comment. Rebased on `main` branch and (should) fix @aaron.ballman portability issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https://reviews.llvm.org/D112916 Files: clang-tools-extra/c

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Lex/Lexer.h:313 + /// getSpelling - This is non-staic variant of getSpelling method which + /// doesn't require

[PATCH] D120484: More explicit message when failing to find a mandatory cfi ressource file

serge-sans-paille created this revision. serge-sans-paille added a reviewer: thakis. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Compiler-rt doesn't provide support file for cfi on s390x ad ppc64le (at least). When tr

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Namely __builtin_alloca __builtin_alloca_with_align __builtin_call_with_st

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille updated this revision to Diff 400080. serge-sans-paille marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117296/new/ https://reviews.llvm.org/D117296 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D117296: Document several clang-supported builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cacd420a1d7: Document several clang-supported builtins (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D117296

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

serge-sans-paille added a comment. The change looks fine to me. I've started a set of benchmark to make sure it provides the expected speedup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169

[PATCH] D118169: [NFC][CodeGen] Use llvm::DenseMap for DeferredDecls

serge-sans-paille accepted this revision. serge-sans-paille added a comment. No performance regression on my side either (but only minor gains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118169/new/ https://reviews.llvm.org/D118169 ___

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:214 mutable llvm::FoldingSet ComplexTypes; - mutable llvm::FoldingSet PointerTypes; + mutable llvm::FoldingSet PointerTypes{9}; mutable llvm::FoldingSet AdjustedTypes; --

[PATCH] D118385: [NFC] Optimize FoldingSet usage where it matters

serge-sans-paille added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:328 /// Add* - Add various data types to Bit data. - void AddPointer(const void *Ptr); - void AddInteger(signed I); - void AddInteger(unsigned I); - void AddInteger(long I); - void Add

[PATCH] D118532: Fix -Wreserved-identifier in presence of system macro

serge-sans-paille created this revision. serge-sans-paille added reviewers: lebedev.ri, aaron.ballman, rsmith. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not warn on reserved identifiers resulting from expansion of

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk. Herald added subscribers: ormris, dexonsmith, jdoerfert, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395677. serge-sans-paille added a comment. Minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395692. serge-sans-paille added a comment. Herald added subscribers: foad, kerbowa, nhaehnle, jvesely, arsenm. remvove useless assert, update comment, fix build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include/llvm/IR/Attributes.h llvm/include/llvm/IR/Fun

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:993 + + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return TargetDepAttrs.empty() && Attrs.none(); } ---

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395713. serge-sans-paille added a comment. Remove `empty()` method and only keep `hasAttributes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llv

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 397225. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116110: Introduce the AttributeMask class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9290ccc3c1a1: Introduce the AttributeMask class (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D116110?vs=3972

<    2   3   4   5   6   7   8   9   >