[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4644727 , @alexfh wrote: > This patch makes clang-format produce invalid JS/TS code > > In D154093#4644512 , @eaeltsin > wrote: > >> This introduces an invalid TS transformation

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGddc80637ccbc: [clang-format] Break long string literals in C#, etc. (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D154093?vs=553729&id=555795#toc Repository: rG LLVM Github

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 553729. sstwcw added a comment. Stop using `SmallString` in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D158697: [clang-format][doc] Correct typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0061fc5e1f: [clang-format][doc] Correct typos (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In the JavaScript tests that I added, it was wrong to use `SmallString`. Would you prefer me changing it to `string` or expanding the 6 test cases so we don't need a variable for the string? Shortly after I committed this patch, the server builds caught the problem in

[PATCH] D158697: [clang-format][doc] Correct typos

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16ccba51072b: [clang-format] Break long string literals in C#, etc. (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG825cec2c0b1e: [clang-format] Add Verilog suffixes to the scripts (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw abandoned this revision. sstwcw added a comment. I am closing it since no one seems to like it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 ___ cfe-c

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547770. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyl

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:221 TEST_F(FormatTestCSharp, CSharpFatArrows) { - verifyFormat("Task serverTask = Task.Run(async() => {"); + verifyIncompleteFormat("Task serverTask = Task.Run(async() => {"); verifyFormat

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 547767. sstwcw marked 2 inline comments as done. sstwcw added a comment. - Add tests for code in JavaScript template strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D15

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. @MyDeveloperDay Can you take a look at the last test in FormatTestCSharp.Attributes? I tried to enable breaking string literals by default. The long string got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw added a comment. In D154093#4544496 , @owenpan wrote: > In D154093#4542339 , @sstwcw wrote: > >> @owenpan What do you think about this revision especially the replacement >> part? > > See D154093#4544495 <

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 547619. sstwcw added a comment. Add support for breaking strings with + in C# and others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangForma

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. @owenpan What do you think about this revision especially the replacement part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 542916. sstwcw added a comment. - Add comment explaining the replacements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked an inline comment as done. sstwcw added a comment. Are there any more problems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-commits ma

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token = createBreakableTo

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540752. sstwcw added a comment. - Add back the const qualifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

sstwcw added a comment. Did you forget about GNU statement expressions? if (({ foo(); bar(); })) { } Comment at: clang/docs/ReleaseNotes.rst:804 - Add ``KeepEmptyLinesAtEOF`` to keep empty lines at end of file. +- Add ``RemoveParenthese`` to remove r

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 537975. sstwcw marked an inline comment as done. sstwcw added a comment. - Drop the line in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. If it is expected that the method does not modify the field, and the expectation is not fulfilled, I prefer to make it clear rather than to pretend that the method works as expected. Can you help me come up with an alternative? Braces need to be added around the string

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537701. sstwcw added a comment. - Add tests for non-whitespace sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. It won't break the string inside an escape sequence. But escape sequences like `\040`, `\x20`, and `\u0020` don't get recognized as whitespace. Comment at: clang/lib/Format/BreakableToken.cpp:199 +if (EscapeSequence && Advance == 2) { + swit

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked an inline comment as done. sstwcw added a comment. In D154091#4470158 , @MyDeveloperDay wrote: > What would happen in a \r\n example If the entire `\r\n` part fits on the first line, the break is after `\r\n`. If only the part up to `\r`

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537190. sstwcw added a comment. - Add tests for other escape sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp c

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 ///const char* x = - /// "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; + ///"veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; /// \endcode -

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D154093#4466246 , @HazardyKnusperkeks wrote: > I'd really prefer you put what you need to modify `mutable` instead of > removing the `const` from everything else. But that's just my opi

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 536555. sstwcw added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clan

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 536531. sstwcw added a comment. - Add tests for newline outside of column limit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToke

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked 2 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:223 - if (SpaceOffset != 0) -return BreakableToken::Split(SpaceOffset + 1, 0); + if (NewLine != 0) +return BreakableToken::Split(NewLine, 0); ---

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw added a comment. See the updated summary. There does not seem to be an issue on GitHub when I searched. I simply noticed it when reading the code in order to understand how strings got broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf66d839f13: [clang-format] Indent Verilog struct literal on new line (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152623/new/ https

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

sstwcw added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:225 +return BreakableToken::Split(NewLine, 0); + if (AfterSpace >= 2) +return BreakableToken::Split(AfterSpace, 0); Should I change the threshold from 2 to 1? It is set to 2 b

[PATCH] D154093: [clang-format] Break strings in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. In Verilog, concatenations need to have braces around them a

[PATCH] D154091: [clang-format] Prefer breaking long strings at new lines

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously, escape sequences in string literals were not rec

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw updated this revision to Diff 533617. sstwcw added a comment. - limit change to Verilog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152623/new/ https://reviews.llvm.org/D152623 Files: clang/lib/Format/ContinuationIndenter.cpp clang/un

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw added a comment. > So I assume your `'` is a 'DictLiteral`? The brace following the quote is a `DictLiteral`. The quote is a `tok::identifier` and `TT_Unknown`. > Does it have to be one? The brace is set to this type when used this way in all other languages. I don't want to make an

[PATCH] D152623: [clang-format] Indent Verilog struct literal on new line

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Before: c = // '{default: 0}; After: c = // '

[PATCH] D151632: [clang-format] Parse the Verilog language option in configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG24231df9b8ef: [clang-format] Parse the Verilog language option in configuration (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151632/ne

[PATCH] D151632: [clang-format] Parse the Verilog language option in configuration

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG369e8762b4d6: [clang-format] Stop comment disrupting indentation of Verilog ports (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. > To this end, I am tracking the previous token type in a stack parallel > to LBraceStack to help scope this particular case. Maybe keep the description up to date with the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

sstwcw added a comment. I would suggest adding a link to the revision on the issue thread for your future bug fixes. This people like me don't try to fix what others have fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 ___

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw abandoned this revision. sstwcw added a comment. I like D150403 better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 __

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw updated this revision to Diff 521667. sstwcw added a comment. - Remove the special case for operator[], it isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150452/new/ https://reviews.llvm.org/D150452 Files: clang/lib/Format

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. > I agree if the brace doesn't start a block, but clang-format sometimes got it > wrong and misannotates a block as a braced list. (See > https://github.com/llvm/llvm-project/issues/33891 for an example.) This patch isn't affected by the problem. The Verilog port list i

[PATCH] D150452: [clang-format] Recognize nested blocks

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Now a block gets recognized as a block if it contains a bloc

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. > IMO a trailing comment (empty or not) belongs to the code before it. There is only a parenthesis before it. It doesn't usually need a comment. It is like in 5a61139. One doesn't tend to comment a single brace. > A comment about the code below it should start on a ne

[PATCH] D149657: [clang-format] Don't indent Verilog `begin` keyword on its own line

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf722b01246d: [clang-format] Don't indent Verilog `begin` keyword on its own line (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149657/

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe12428557a45: [clang-format] Recognize Verilog edge identifiers (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149561/new/ https://revi

[PATCH] D149657: [clang-format] Stop indent Verilog `begin` keyword on single line

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. When the line is too long and the `begin` keyword wraps to t

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

sstwcw updated this revision to Diff 518752. sstwcw added a comment. - add annotator test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149561/new/ https://reviews.llvm.org/D149561 Files: clang/lib/Format/FormatToken.h clang/unittests/Format/F

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw added a comment. In D149562#4310396 , @HazardyKnusperkeks wrote: > I don't see the problem, could you elaborate a bit more? (Keep in mind, I > have no idea about Verilog.) The current way the port list gets formatted is like this: module x

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Before: module x #( // parameter x)

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously the event expression would be misidentified as a

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82a90caa88fd: [clang-format] Correctly format goto labels followed by blocks (authored by sstwcw). Changed prior to commit: https://reviews.llvm.o

[PATCH] D149352: [clang-format] Recognize Verilog type dimension in module header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4134f836103e: [clang-format] Recognize Verilog type dimension in module header (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149352: [clang-format] Recognize Verilog type dimension in module header

sstwcw created this revision. sstwcw added a reviewer: curdeius. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. We had the function `veri

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw added a comment. Is this patch accepted or rejected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148484/new/ https://reviews.llvm.org/D148484 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4525 -const FormatToken *Next = Right.getNextNonComment(); -if (!Next || Next->is(tok::semi)) return false; MyDeveloperDay wrote:

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw updated this revision to Diff 514249. sstwcw added a comment. - Remove change in line wrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148484/new/ https://reviews.llvm.org/D148484 Files: clang/lib/Format/FormatToken.h clang/lib/Fo

[PATCH] D148482: [clang-format][NFC] Output tokens on test assert

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6301a018d58: [clang-format][NFC] Output tokens on test assert (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:714 // are in a control flow statements as well as several style flags. -if (Line.First->is(tok::kw_case) || +if (Line.First->is(tok::kw_case) || Line.Last->is(TT_GotoLabelColon) ||

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. There doesn't seem to be an issue on GitHub. But previously

[PATCH] D148482: [clang-format][NFC] Output tokens on test assert

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0571ba8d1b4d: [clang-format] Handle Verilog assertions and loops (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D147895?v

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

sstwcw added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:844 "};"); - ASSERT_EQ(Tokens.size(), 44u); + ASSERT_EQ(Tokens.size(), 44u) << Tokens; EXPECT_TOKEN(Tokens[13], tok::kw_requires, TT_RequiresClause);

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

sstwcw added a comment. Herald added a project: All. Herald added reviewers: rymiel, owenpan. A goto label isn't affected by this option. Is it intentional? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ https://reviews.llvm.org/D93240

[PATCH] D147895: [clang-format] Handle Verilog assertions and loops

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. sstwcw requested review of this revision. Assert statements in Verilog can optionally have an else par

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

sstwcw added inline comments. Comment at: clang/docs/tools/dump_format_style.py:72 - subtype, napplied = re.subn(r'^std::vector<(.*)>$', r'\1', typestr) - if napplied == 1: -return 'List of ' + pluralize(to_yaml_type(subtype)) + match = re.match(r'std::vector<(.*)>$', ty

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8385ee05e59d: [clang-format] NFC Document the other space before colon option (authored by sstwcw). Changed prior to commit: https://reviews.llvm.

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74cc4389f37d: [clang-format] Add option for having one port per line in Verilog (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw added a comment. In D147422#4240024 , @MyDeveloperDay wrote: > In D147422#4240021 , @owenpan wrote: > >> Should we extend `SpacesInContainerLiterals` so that it controls JSON colons >> too? If yes, then w

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added subscribers: cfe-commits, JDevlieghere. Herald added projects: All, clang, clang-format. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510385. sstwcw added a comment. - Use lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Form

[PATCH] D147329: [clang-format] Handle Verilog struct literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfeb585e7d62c: [clang-format] Handle Verilog struct literals (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147328: [clang-format] Handle enum in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92b2be39656b: [clang-format] Handle enum in Verilog (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D147328?vs=510031&id=5

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510244. sstwcw marked 2 inline comments as done. sstwcw added a comment. - Use shorter conditions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/C

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510038. sstwcw added a comment. Generate doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Form

[PATCH] D147329: [clang-format] Handle Verilog struct literals

sstwcw created this revision. Herald added subscribers: cfe-commits, ctetreau. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously `isVerilogIdentifier` was mistaking the

[PATCH] D147328: [clang-format] Handle enum in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Verilog has enum just like C. Repository: rG LLVM Github

[PATCH] D147327: [clang-format] Add option for having one port on a line in Verilog

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated Re

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cef325481a8: [clang-format] Don't squash Verilog escaped identifiers (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D146

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e01c3d28217: [clang-format] More work on space around operators in Verilog (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D146402: [clang-format] Handle Verilog assign statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf90668c8ccc5: [clang-format] Handle Verilog assign statements (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897 } +} // namespace +} // namespace test MyDeveloperDay wrote: > is this correct? do you have an anonymous namespace? It is correct.

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

sstwcw updated this revision to Diff 506457. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146403/new/ https://reviews.llvm.org/D146403 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestVerilog.cpp Index: clang/unittes

[PATCH] D146403: [clang-format] More work on space around operators in Verilog

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. before: (opcode *>o1) = 6.1; a inside{b, c};

[PATCH] D146402: [clang-format] Handle Verilog assign statements

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An escaped identifier always needs a space follow

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb688b58f83ce: [clang-format] Fix non-case colons in Verilog case lines (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4424 -if (Line.First->isOneOf(tok::kw_default, tok::kw_case)) - return Style.SpaceBeforeCaseColon; const FormatToken *Next = Right.getNextNonCommen

[PATCH] D145794: [clang-format] Recognize Verilog always blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f8bab9bad7: [clang-format] Recognize Verilog always blocks (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Back in D128714

[PATCH] D145794: [clang-format] Recognize Verilog always blocks

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. sstwcw added a project: clang-format. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The small `

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e473aeffdc1: [clang-format] Put ports on separate lines in Verilog module headers (authored by sstwcw). Changed prior to commit: https://reviews.

  1   2   3   >