[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. I split out the support for building inferred modules explicitly: D102491 . Patch with changes to the dependency scanner will follow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/modules-inferred-explicit-build.m:13-17 +// RUN: %clang @%t.inferred.rsp -pedantic -Werror +// RUN: %clang @%t.system.rsp -pedantic -Werror +// RUN: %clang -x objective-c -fsyntax-only

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. In D100934#2737130 , @dexonsmith wrote: > In D100934#2735955 , @jansvoboda11 > wrote: > >> 1. Fix `AsWritten` for umbrella headers/directories. >> 2. Add tests to

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added a comment. In D100934#2735955 , @jansvoboda11 wrote: > In D100934#2733857 , @dexonsmith > wrote: > >> Given that there are four different things being done in this commit, it >> sounds naively

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. In D100934#2733857 , @dexonsmith wrote: > Given that there are four different things being done in this commit, it > sounds naively like it should be four separate commits. If the logic is too > intertwined to land each

[PATCH] D100934: [clang][modules] Build inferred modules

dexonsmith added a comment. Given that there are four different things being done in this commit, it sounds naively like it should be four separate commits. If the logic is too intertwined to land each of the four pieces separately (certainly possible), can you quickly explain why, to motivate

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added a comment. @dexonsmith ping Comment at: clang/lib/Serialization/ASTReader.cpp:5621 + // FIXME: NameAsWritten + ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, ""); else if (CurrentModule->getUmbrellaHeader().Entry !=

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5621 + // FIXME: NameAsWritten + ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, ""); else if (CurrentModule->getUmbrellaHeader().Entry != *Umbrella) {

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 340478. jansvoboda11 added a comment. Fix clang-tidy warnings, add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files:

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 340461. jansvoboda11 added a comment. Rebase on top of D101051 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files:

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 339187. jansvoboda11 added a comment. Rebase on top of D100942 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files:

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 updated this revision to Diff 339136. jansvoboda11 added a comment. Apply clang-format suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 Files: clang/include/clang/Basic/Module.h

[PATCH] D100934: [clang][modules] Build inferred modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch enabled explicitly building inferred modules. Effectively a cherry-pick of