[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82f92e35c646: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively accepted this revision. tlively added a comment. In D101140#2789199 , @wingo wrote: > Quick r? to @tlively -- OK with having the new util function in > WebAssemblyFrameLowering? It didn't work to have it in the utils library > because the

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. Quick r? to @tlively -- OK with having the new util function in WebAssemblyFrameLowering? It didn't work to have it in the utils library because the function needs the vtable of WebAssemblyFunctionInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348758. wingo added a comment. Fix shared-library build by moving util function to WebAssemblyFrameLowering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo reopened this revision. wingo added a comment. This revision is now accepted and ready to land. Yarrrgh, broke the shared library build. Fix incoming... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf35f4af51cd: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786870 , @jrtc27 wrote: > In D101140#2786844 , @wingo wrote: > >> In D101140#2786777 , @jrtc27 wrote: >> >>> Is it just me or does

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

jrtc27 added a comment. In D101140#2786844 , @wingo wrote: > In D101140#2786777 , @jrtc27 wrote: > >> Is it just me or does having a backend-specific type in target-independent >> code feel wrong? It feels like

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786777 , @jrtc27 wrote: > Is it just me or does having a backend-specific type in target-independent > code feel wrong? It feels like there should be a space for target-specific > TargetStackIDs... Hoo, good

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

jrtc27 added a comment. Is it just me or does having a backend-specific type in target-independent code feel wrong? It feels like there should be a space for target-specific TargetStackIDs... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348493. wingo added a comment. Herald added subscribers: foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal,

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ecf18979e3: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348467. wingo added a comment. Adapt test to insert compiler barrier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/ir-locals.ll:17-20 + ; The DAG combiner infers that %reloaded is the same as %arg and + ; ultimately causes "local.get 0" to be emitted instead of + ; "local.get 1". + ; CHECK-NEXT: local.get 0

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM with that one last comment on the test. Comment at: llvm/test/CodeGen/WebAssembly/ir-locals.ll:17-20 + ; The DAG combiner infers that %reloaded is the same as %arg

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. Gentle ping here to @tlively :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:351 IO.enumCase(ID, "scalable-vector", TargetStackID::ScalableVector); +IO.enumCase(ID, "object", TargetStackID::Object); IO.enumCase(ID, "noalloc", TargetStackID::NoAlloc);

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 346990. wingo marked 4 inline comments as done. wingo added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 346986. wingo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: llvm/include/llvm/CodeGen/MIRYamlMapping.h

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 344323. wingo added a comment. Update in response to parent commit changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 343367. wingo added a comment. Rename "object" to "managed", and add test for stack id Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files:

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

tlively added inline comments. Comment at: llvm/include/llvm/CodeGen/MIRYamlMapping.h:351 IO.enumCase(ID, "scalable-vector", TargetStackID::ScalableVector); +IO.enumCase(ID, "object", TargetStackID::Object); IO.enumCase(ID, "noalloc", TargetStackID::NoAlloc);

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 342698. wingo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang datalayout expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/