[PATCH] D101479: [Driver] Support libc++ in MSVC

hofst added a comment. I was looking forward to this change in clang 16 but just noticed that you had to revert the change again at August 18 2022. @phosek Do you still plan to work on this change? Is there any way I could help? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4230319f7af: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2813797 , @phosek wrote: > In D101479#2813724 , @mstorsjo > wrote: > >> Couldn’t this commit have been kept in, and just reverting the one for using >> it in the fuchsia cmak

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2813724 , @mstorsjo wrote: > Couldn’t this commit have been kept in, and just reverting the one for using > it in the fuchsia cmake cache? (I’m not using this particular commit myself, > just observing.) The problem i

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. Couldn’t this commit have been kept in, and just reverting the one for using it in the fuchsia cmake cache? (I’m not using this particular commit myself, just observing.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1014

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rG9625d61eb66c: [Driver] Support libc++ in MSVC (authored by phosek). Herald added a subscriber: dang. Changed prior to commit: https://reviews.llvm.org/D101479?vs=347213&id=350507#toc Repository: rG L

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb604301be355: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry for the delay, this fell off the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. Ping, is this OK to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2750765 , @amccarth wrote: > Ah, thanks for explaining that! In the VC++ stack, `/MD` and `/MT` make the > DLL/static choice for the CRT, the C++ standard library, and the compiler > runtime.[1] It never occurred t

[PATCH] D101479: [Driver] Support libc++ in MSVC

amccarth added a comment. In D101479#2748475 , @mstorsjo wrote: > In D101479#2748189 , @amccarth > wrote: > >> In D101479#2733354 , @mstorsjo >> wrote: >> >>> Not sure i

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2748189 , @amccarth wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`

[PATCH] D101479: [Driver] Support libc++ in MSVC

amccarth added a comment. In D101479#2733354 , @mstorsjo wrote: > Not sure if we want the desicion between static and shared libc++ be coupled > with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static > libc++ with `/MD`. I don't und

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 343507. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs/msvc_libcxx_tree/usr/bin/.keep clang/t

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2741223 , @phosek wrote: > In D101479#2741202 , @mstorsjo > wrote: > >> In D101479#2740895 , @phosek wrote: >> >>> On other platforms

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2741202 , @mstorsjo wrote: > In D101479#2740895 , @phosek wrote: > >> On other platforms the decision whether to use static or shared is >> controlled by `-static-libstdc++`, do

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2740895 , @phosek wrote: > On other platforms the decision whether to use static or shared is controlled > by `-static-libstdc++`, does CL have a similar flag or shall we support > `-static-libstdc++` in MSVC driver

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. In D101479#2733622 , @mstorsjo wrote: > In D101479#2733434 , @thakis wrote: > >> In D101479#2733354 , @mstorsjo >> wrote: >> >>> Not sure if we wa

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2733434 , @thakis wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`,

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. In D101479#2733354 , @mstorsjo wrote: > Not sure if we want the desicion between static and shared libc++ be coupled > with `/MT` and `/MD`, as one can quite plausibly want to use e.g. a static > libc++ with `/MD`. Right, I mean

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added subscribers: smeenai, mstorsjo. mstorsjo added a comment. In D101479#2733303 , @thakis wrote: > How does this interact with `/MT` / `/MD`? Does this link the static or the > dynamic libc++? If the former, does that do the right thing for D

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. How does this interact with `/MT` / `/MD`? Does this link the static or the dynamic libc++? If the former, does that do the right thing for DLLs? If the latter, are users expected to manually copy libc++.dll? (Sorry, not super up to speed on the static/shared lib status

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek updated this revision to Diff 341652. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/Inputs

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk added a comment. The test doesn't seem to pass on Jenkins. Maybe we need a REQUIRES line or a fake sysroot or something for the test. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1332 + + auto AddLibcxxIncludePath = [&](StringRef Path) { +std::string Version = det

[PATCH] D101479: [Driver] Support libc++ in MSVC

thakis added a comment. can you add a test for the linker invocation too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 ___ cfe-commits mailing list cfe-commi

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek created this revision. phosek added reviewers: hans, rnk, thakis. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements support for using libc++ headers in MSVC toolchain. We only support libc++ headers that are part