gandhi21299 marked 2 inline comments as done.
gandhi21299 added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
--
rampitec added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
gandhi21299 wrote:
> rampitec wrote:
>
gandhi21299 added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
rampitec wrote:
> gandhi21299 wrote
rampitec added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
gandhi21299 wrote:
> rampitec wrote:
>
gandhi21299 added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
rampitec wrote:
> gandhi21299 wrote
rampitec added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:631
+"at "
+ << (AI->getSyncScopeID() ? "system" : "single thread")
+ << " memory scope");
gandhi21299 wrote:
> rampitec wrote:
>
gandhi21299 updated this revision to Diff 366112.
gandhi21299 added a comment.
requested changes from reviewer
- added memory scope tests and updated remarks and tests accordingly
- still working on clang/test/CodeGenCUDA/fp-atomics-optremarks.cu and
clang/test/CodeGenOpenCL/atomics-remarks-gfx9
rampitec added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:618
expandAtomicRMWToCmpXchg(AI, createCmpXchgInstFun);
+ Ctx.getSyncScopeNames(SSNs);
+ auto MemScope = SSNs[AI->getSyncScopeID()].empty()
Only if SSNs.empty().
gandhi21299 added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic_add_casPf
rampitec wrote:
>
rampitec added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic_add_casPf
gandhi21299 wrote:
>
gandhi21299 added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:618
expandAtomicRMWToCmpXchg(AI, createCmpXchgInstFun);
+ Ctx.getSyncScopeNames(SSNs);
+ auto MemScope = SSNs[AI->getSyncScopeID()].empty()
rampitec wrote:
> Onl
gandhi21299 added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic_add_casPf
rampitec wrote:
>
rampitec added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic_add_casPf
gandhi21299 wrote:
>
gandhi21299 marked 4 inline comments as done.
gandhi21299 added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic
gandhi21299 updated this revision to Diff 366131.
gandhi21299 added a comment.
- corrected atomics-remarks-gfx90a.cl test to emit remark as well
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
Files:
cl
rampitec added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic_add_casPf
gandhi21299 wrote:
>
gandhi21299 updated this revision to Diff 366127.
gandhi21299 added a comment.
- corrected remarks by replacing the operation name and updated tests
accordingly
- code format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://review
gandhi21299 updated this revision to Diff 366132.
gandhi21299 marked 3 inline comments as done.
gandhi21299 added a comment.
no way to pass memory_scope in `__atomic_fetch_add(...)`, discarded the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
gandhi21299 marked an inline comment as done.
gandhi21299 added inline comments.
Comment at: clang/test/CodeGenCUDA/fp-atomics-optremarks.cu:10
+
+// GFX90A-CAS: A compare and swap loop was generated for an atomic operation
at system memory scope
+// GFX90A-CAS-LABEL: _Z14atomic
gandhi21299 marked an inline comment as done.
gandhi21299 added inline comments.
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:585
+ TLI->shouldExpandAtomicRMWInIR(AI, ORE);
+ OptimizationRemark Remark(DEBUG_TYPE, "Passed", AI->getFunction());
+ switch (Kind) {
---
gandhi21299 updated this revision to Diff 366294.
gandhi21299 added a comment.
- added clang/test/CodeGenCUDA/fp-atomics-optremarks.cu back
- moved `Remark` declaration into the `else` block
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
gandhi21299 updated this revision to Diff 366301.
gandhi21299 added a comment.
- rebased against main branch
- cleaned up code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new/
https://reviews.llvm.org/D106891
Files:
clang/test/CodeGenCU
rampitec added a comment.
Please retitle it without AMDGPU and remove the changes to pass ORE to targets.
It is not a part of this change, it is a part of the folloup target specific
change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106891/new
23 matches
Mail list logo
