[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947914 , @vitalybuka wrote: > Do we have public bot for hexagon? I think we have one intended to for checking hexagon-unknown-elf and perhaps not one for hexagon-unknown-linux-musl. I believe that only the Linux targe

[PATCH] D108083: add sanitizer support to hexagon

bcain added a comment. In D108083#2947907 , @vitalybuka wrote: > Can you cut this into separate peaces, at least patch per sanitizer for "asan > lsan ubsan scudo scudo_standalone cfi safestack"? Sure, that's no problem. While I'm breaking it up, us the

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Do we have public bot for hexagon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108083/new/ https://reviews.llvm.org/D108083 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D108083: add sanitizer support to hexagon

vitalybuka added a comment. Can you cut this into separate peaces, at least patch per sanitizer for "asan lsan ubsan scudo scudo_standalone cfi safestack"? Some common peaces could be probably extracted as well. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_

[PATCH] D108083: add sanitizer support to hexagon

sidneym added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124 + +bool internal_iserror(uptr retval, int *rverrno) { + if (retval == (uptr)-1) { bcain wrote: > @sidneym Can you confirm that this implementatio

[PATCH] D108083: add sanitizer support to hexagon

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:297-298 +linkSanitizerRuntimeDeps(HTC, CmdArgs); +// FIXME: sanitizer_common or only some require unwind? +CmdArgs.push_back("-lunwind"); + } I will try