vhscampos updated this revision to Diff 376228.
vhscampos edited the summary of this revision.
vhscampos added a comment.
1. Disable the cryptographic extensions by default.
2. Small fix in TargetParserTest.cpp to include different spellings of the
-march values.
Repository:
rG LLVM Github Mo
vhscampos added a comment.
To the relevant persons I have just added to the review: @srhines
@nickdesaulniers @llozano
The cryptographic extensions will **//NOT//** be enabled by default on Armv9-A
and on Armv9-A ARM CPUs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A,
Armv9.1-A and Armv9.2-A (authored by vhscampos).
Repository:
rG LLVM Github Monorepo
vhscampos created this revision.
Herald added subscribers: dexonsmith, hiraditya, kristof.beyls.
vhscampos requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
armv9-a, armv9.1-a and armv9.2-a can be targeted using the -march o
SjoerdMeijer added reviewers: t.p.northover, ab.
SjoerdMeijer added a comment.
Some first comments after just looking at the plumbing for these new options.
Didn't check yet the architecture extensions for the different version.
Comment at: clang/lib/Driver/ToolChains/Arch/AAr
vhscampos updated this revision to Diff 372473.
vhscampos marked 3 inline comments as done.
vhscampos added a comment.
1. Enable the SVE2 extension as default.
2. Remove out of date comments in tests.
3. Remove unrelated change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vhscampos added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:413
- auto V8_6Pos = llvm::find(Features, "+v8.6a");
- if (V8_6Pos != std::end(Features))
-V8_6Pos = Features.insert(std::next(V8_6Pos), {"+i8mm", "+bf16"});
+ const char *Archs[] =
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Thanks, looks reasonable to me.
Comment at: llvm/unittests/Support/TargetParserTest.cpp:495
ARMBuildAttrs::CPUArch::v8_A));
+ EXPECT_T
vhscampos updated this revision to Diff 373943.
vhscampos added a comment.
1. Fix bug in "+sve2" feature position in the target features list. It was
being inserted at the end, which made it impossible to disable it using
+nosve2, as the positive option would always be placed after the negative
vhscampos requested review of this revision.
vhscampos added a comment.
Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the
latest comment). Therefore I kindly ask another round of review, please.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:419
+
+ // Enable SVE2 by default on Armv9-A
+ // It can still be disabled if +nosve2 is present
-
vhscampos updated this revision to Diff 374162.
vhscampos added a comment.
Add missing . to end of sentences in comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109517/new/
https://reviews.llvm.org/D109517
Files:
clang/lib/Basic/Targets/A
12 matches
Mail list logo