[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4195ed995993: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws (authored by Conanap). Changed prior to commit: https://reviews.llvm.org

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk added a comment. Additional nits regarding comments. Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:20 ; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-BE-P9 ; xscvdpsxws and uxws is only available on Power7 and above ; Codgen is different for LE

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 ___ cfe-commits mailing list cfe-comm

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 375780. Conanap marked an inline comment as done. Conanap added a comment. Updated correct version of the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I really don't understand what happened now. It seems that you have simply reverted to an older version of this patch. The test case appears to not have been pre-committed any lo

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap marked 2 inline comments as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:4150 +0))>; +def : Pat<(v4i32 (insertelt v4i32:$VEC, DblToUInt.A, 0)), + (v4i32 (XXINSERTW v4i32:$VEC,

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 375667. Conanap added a comment. Added context, changed var names in aptterns CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/tes

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I cannot tell without context whether the codegen changes for the `f32->i32` convert + insert case (for example `@test2` in `test/CodeGen/PowerPC/test-vector-insert.ll`) but it s

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374906. Conanap added a comment. This modifies a test case introduced in this commit: https://github.com/llvm/llvm-project/commit/3678df5ae6618eec656ae0ea0dab3be09d73bc9a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llv

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. There isn't enough information in the test to determine whether this adequately improves code generation (in fact, whether it improves code generation at all).

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 ___

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374614. Conanap added a comment. Added P7 and P8 run lines for BE CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/Power

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap marked 3 inline comments as done. Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/test-vector-insert.ll:8 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr7 < %s | FileCheck %s + kamaub wrote: > It

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374578. Conanap added a comment. Updated test cases, fixed a typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/test-vector-ins

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrVSX.td:2815 +def : Pat<(v4i32 (PPCSToV DblToUInt.A)), + (v4i32 (SUBREG_TO_REG (i64 1), (XSCVDPSXWS f64:$A), sub_64))>; defm : ScalToVecWPermute< This should be `XSCVDPUXWS`? =

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 374059. Conanap marked an inline comment as done. Conanap added a comment. Removed AIX test line as it has the same code gen as BE CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/P

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

kamaub added a reviewer: kamaub. kamaub added a comment. This patch seems almost ready to land to me, I'm just a bit concerned about the testing coverage, is the little endian testing case suppose to target `pwr7` as the big endian test does? The default FileCheck line seems redundant to me, d

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 373045. Conanap edited the summary of this revision. Conanap added a comment. Removed complexity and restored a test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PP

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 373009. Conanap added a comment. Removed unintended change, moved pattern to more appropriate location, reduced added complexity to 600 as it still works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 F

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap created this revision. Conanap added reviewers: PowerPC, nemanjai, saghir. Conanap added projects: PowerPC, LLVM, clang. Herald added subscribers: kbarton, hiraditya. Conanap requested review of this revision. This patch removes the uneccessary mf/mtvsr generated in conjunction with xscvdp