[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG607fb1bb8c91: [AArch64] Always add -tune-cpu argument to -cc1 driver (authored by david-arm). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @david-arm, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits m

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380663. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aarch64-mtune.c llvm/docs/ReleaseNotes.rst llvm/

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Thanks. I'm happy as soon as everyone else is happy with the wording. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added inline comments. Comment at: clang/test/Driver/aarch64-mtune.c:5 +// RUN: %clang -target aarch64-unknown-unknown -c -### %s 2>&1 \ +// RUN: | FileCheck %s -check-prefix=notune +// notune-NOT: "-tune-cpu" "generic" sdesmalen wrote: > nit: Did you

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

sdesmalen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:185-188 +architectural features. For example, we can compile code with +"-mcpu=generic -mtune=cortex-a57" where the architectural features are +defined according to a "generic" CPU, but we use the scheduling

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380649. david-arm added a comment. - Added release notes for both clang and llvm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolChains/Clang.

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. There are clang release notes that could also do with a line or two, after all the -mtune flag being a clang flag. The X86 notes for reference were added in https://releases.llvm.org/12.0.0/docs/ReleaseNotes.html and https://releases.llvm.org/12.0.0/tools/clang/docs/Rel

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 380325. david-arm added a comment. - Added something to the ReleaseNotes file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/aarch64-m

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Now that we have the tests on the D111551 side, I think this patch LGTM. Do you think it's worth adding something to the release notes? "-mtune now actually works for AArch64". But, umm, perhaps better written than that. CHANGES SINC

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3057380 , @david-arm wrote: > In D110258#3055488 , @dmgreen wrote: > >> If D111551 was folded into this patch, >> would it be possible to add

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. In D110258#3055488 , @dmgreen wrote: > If D111551 was folded into this patch, > would it be possible to add tests for -tune-cpu enabling/disabling features > at the correct times? Similar to

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. If D111551 was folded into this patch, would it be possible to add tests for -tune-cpu enabling/disabling features at the correct times? Comment at: clang/test/Driver/aarch64-mtune.c:3 + +// There shouldn't be a defa

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Gentle ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 378180. david-arm marked an inline comment as done. david-arm added a comment. - Fixed formatting issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110258/new/ https://reviews.llvm.org/D110258 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. In D110258#3024418 , @david-arm wrote: > Hi @dmgreen, would you be happy for me to do the splitting-out of arch and > tuning features in a separate follow-on patch? I think it's a good idea and I > don't object to doing it, but

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. Hi @dmgreen, would you be happy for me to do the splitting-out of arch and tuning features in a separate follow-on patch? I think it's a good idea and I don't object to doing it, but I'm not sure that it really needs to hold up this initial patch? I personally think i

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. I think these are the features I would class as tuning: FeatureExperimentalZeroingPseudos FeatureZCRegMove FeatureZCZeroingGP FeatureNoZCZeroingFP FeatureZCZeroing FeatureZCZeroingFPWorkaround FeatureStrictAlign FeatureBalanceFPOps FeaturePredictableSele

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. I think ProcessorModel is class ProcessorModel f, list tunef = []> So we are always currently passing tunef = [] from AArch64 and passing all features through f. They need to be split out and then hopefully the call to ParseSubtargetFeatures w

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm added a comment. In D110258#3023818 , @dmgreen wrote: > Sounds great. Glad to see us taking this route. > > Unfortunately I think we do need to split the subtargetfeatures up into arch > flags and tune flags. Same for the details in > AArch64

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. Sounds great. Glad to see us taking this route. Unfortunately I think we do need to split the subtargetfeatures up into arch flags and tune flags. Same for the details in AArch64Subtarget::initializeProperties. It is hopefully a fairly mechanical process, but they are

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

david-arm updated this revision to Diff 375169. david-arm retitled this revision from "[AArch64][Clang] Always add -tune-cpu argument to -cc1 driver" to "[AArch64] Always add -tune-cpu argument to -cc1 driver". david-arm edited the summary of this revision. david-arm added a comment. Herald added