[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. Thanks for the feedback. I'll work on a follow-up that implements that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 ___ cfe-commits

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

aaron.ballman added a comment. In D110668#3038858 , @xbolva00 wrote: > In D110668#3036361 , @thakis wrote: > >> In D110668#3034576 , @xbolva00 >> wrote: >> >>> Please nex

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. > What I mean, for example: > > def UnusedParameter : DiagGroup<"unused-parameter", 4100>; That's an interesting idea. Given how seldom this is used, I weakly prefer having actual code for this though: It makes it easy to see all of those mapped flags, and it keeps ra

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

xbolva00 added a subscriber: aaron.ballman. xbolva00 added a comment. In D110668#3036361 , @thakis wrote: > In D110668#3034576 , @xbolva00 > wrote: > >> Please next time give a bit more time to potential reviewer

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. In D110668#3034576 , @xbolva00 wrote: > Please next time give a bit more time to potential reviewers / other folks > outside your org. The whole lifecycle of this patch (posted - landed) took < > 24h. Is there anything wrong wit

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

xbolva00 added a comment. Please next time give a bit more time to potential reviewers / other folks outside your org. The whole lifecycle of this patch (postee - landed) took < 24h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added a comment. Thanks for the revert. The problem was that this `continue` was in the wrong spot: diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 9450e8b154c5..369c12aea523 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

akhuang added a comment. Seems like there are also errors in chrome builds and the llvm compiler-rt build, will just revert it for now -- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 _

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

haowei added a comment. We are seeing a series of weird errors in our windows clang builder after this patch landed: [1/828] Building CXX object compiler-rt\lib\sanitizer_common\CMakeFiles\RTSanitizerCommonNoTermination.x86_64.dir\sanitizer_solaris.cpp.obj FAILED: compiler-rt/lib/sanitizer

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. thakis marked an inline comment as done. Closed by commit rGb2de52bec17b: [clang-cl] Accept `#pragma warning(disable : N)` for some N (authored by thakis). Changed pri

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! lgtm Comment at: clang/include/clang/Basic/CLWarnings.h:18 +enum class Group; +}; + clang-tidy's comment about the extra semicolon seems valid CHANGES SI

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375891. thakis added a comment. Herald added subscribers: usaxena95, arphaman. tblgen group IDs Done, please take a look. We now have a `diag::Group` enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 F

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis added inline comments. Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; hans wrote: > Would it be possible to reference the DiagGroup symbolically here some

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

hans added a comment. Nice! Comment at: clang/lib/Basic/CLWarnings.cpp:17 + switch (CLWarningID) { + case 4005: return "macro-redefined"; + case 4018: return "sign-compare"; Would it be possible to reference the DiagGroup symbolically here somehow instead o

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375750. thakis added a comment. tweak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 Files: clang/include/clang/Basic/CLWarnings.h clang/include/clang/Driver/Options.td clang/lib/Basic/CLWarnings.cpp

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375749. thakis added a comment. some clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 Files: clang/include/clang/Basic/CLWarnings.h clang/include/clang/Driver/Options.td clang/lib/Basic/CL

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. Herald added subscribers: dexonsmith, dang, mgorny. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. clang-cl maps /wd to -Wno-flags for a