This revision was automatically updated to reflect the committed changes.
Closed by commit rGc7104e506619: [Sema] Allow comparisons between different ms
ptr size address space types. (authored by akhuang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110670/new/
https://reviews.llvm.org/D110670
akhuang updated this revision to Diff 376936.
akhuang added a comment.
add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110670/new/
https://reviews.llvm.org/D110670
Files:
clang/lib/Sema/SemaExprCXX.cpp
aaron.ballman added inline comments.
Comment at: clang/test/Sema/MicrosoftExtensions.cpp:9-10
+ return (p32u == p32s) +
+ (p32u == p64) +
+ (p32s == p64);
+}
akhuang wrote:
> aaron.ballman wrote:
> > (Side question, not directly about this patch
akhuang added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682
+ isPtrSizeAddressSpace(Q2.getAddressSpace()))
+MaybeQ1 = true;
+ else
aaron.ballman wrote:
> akhuang wrote:
> > aaron.ballman wrote:
> > > I'm
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682
+ isPtrSizeAddressSpace(Q2.getAddressSpace()))
+MaybeQ1 = true;
+ else
akhuang wrote:
> aaron.ballman wrote:
> > I'm pretty sure this is
akhuang added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682
+ isPtrSizeAddressSpace(Q2.getAddressSpace()))
+MaybeQ1 = true;
+ else
aaron.ballman wrote:
> I'm pretty sure this is correct based on my inspection
aaron.ballman added reviewers: rnk, majnemer.
aaron.ballman added inline comments.
Comment at: clang/lib/Sema/SemaExprCXX.cpp:6682
+ isPtrSizeAddressSpace(Q2.getAddressSpace()))
+MaybeQ1 = true;
+ else
I'm pretty sure this is
akhuang created this revision.
akhuang added a reviewer: aaron.ballman.
akhuang requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We're currently using address spaces to implement __ptr32/__ptr64 attributes;
this patch fixes a bug where
