This revision was automatically updated to reflect the committed changes.
Closed by commit rG6831c1d8689b: [clangd] Include refs of base method in refs
for derived method. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111039/
usaxena95 marked an inline comment as done.
usaxena95 added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1397
+ OverriddenBy.Subjects.insert(ID);
getOverriddenMethods(CMD, OverriddenMethods);
}
kadircet
usaxena95 updated this revision to Diff 377114.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111039/new/
https://reviews.llvm.org/D111039
Files:
clang-to
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/XRefs.cpp:1397
+ OverriddenBy.Subjects.insert(ID);
getOverriddenMethods(CMD, OverriddenMeth
usaxena95 updated this revision to Diff 377111.
usaxena95 marked 3 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111039/new/
https://reviews.llvm.org/D111039
Files:
clang-to
hokein added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1395
if (CMD->isVirtual())
-if (IdentifierAtCursor && SM.getSpellingLoc(CMD->getLocation()) ==
- IdentifierAtCursor->location()) {
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/XRefs.cpp:1395
if (CMD->isVirtual())
-if (IdentifierAtCursor && SM.getSpellingLoc(CMD->getLocation()) ==
- IdentifierAtCursor->location()) {
--
usaxena95 created this revision.
usaxena95 added reviewers: hokein, kadircet.
Herald added a subscriber: arphaman.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Addresses https://github.com/cla