[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b9a7f42870: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin (authored by jeremyd2019, committed by mstorsjo). Repository:

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95 ___ cfe-commits mailing list cfe-commi

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 updated this revision to Diff 377590. jeremyd2019 added a comment. Switched to #ifdef _WIN32 instead of checking triple CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95 Files: clang/lib/Tooling/JSONCompilationDatabase.cpp Index:

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

rnk added a comment. In D95#3044594 , @mstorsjo wrote: > This looks ok to me I guess. Technically in this case, this is pretty much > equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where > the process considers itself windows

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

mstorsjo added a subscriber: rnk. mstorsjo added a comment. This looks ok to me I guess. Technically in this case, this is pretty much equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define `_WIN32`), but I guess k

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Also, I don't have push access so someone would need to push this for me assuming it is approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 added a comment. Note that I found this due to a report of a crash in clangd , but I don't actually use that so just looked through the code for what was messing with paths. Users on that bug report confirmed that this fixed thei

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

jeremyd2019 created this revision. jeremyd2019 added reviewers: mstorsjo, rsmith. jeremyd2019 added a project: clang. jeremyd2019 requested review of this revision. Herald added a subscriber: cfe-commits. Previously it only used Windows command lines for MSVC triples, but this was causing issues