[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4bf1b449dc0: [RISCV] Unify depedency check and extension implication parsing logics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11235

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 393181. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clan

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 390187. eopXD added a comment. - Update code (zfh have been added recently. - Added test case `attribute-arch-invalid.s` to show that experimental extensions need to specify the version explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. OK, that reasoning makes sense. I think my only outstanding request would be to ensure there's some test coverage for the case of .attribute arch with an experimental extension without version info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. ping, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. @asb Thanks for the reply. To clarify the question, the 2 inconsistencies are: - Test cases with `clang -cc1` originally don't do dependency check to target feature specified (handled by `parseFeatures`) - Clang driver's -march enforces version to be specified, while llvm

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. In D112359#3098960 , @eopXD wrote: > > Add version numbers for test case in `attribute-arch.s` Thanks for updating the patch. Why change this test case? I thought those lines were verifying that .attribute arch without a version

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383775. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383733. eopXD added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383647. eopXD added a comment. Set `ExperimentalExtensionVersionCheck=true` for RISCVISAInfo::parseArchString in `RISCVAsmParser.cpp` Add version numbers for test case in `attribute-arch.s` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383607. eopXD added a comment. Address comment: Enforce user to specify version checks. @asb Thank you for leaving comments for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://revie

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 383606. eopXD added a comment. Herald added subscribers: VincentWu, luke957. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/ri

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

luke957 resigned from this revision. luke957 added a comment. So sorry for my bad herald script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 ___ cfe-commits

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

asb added a comment. Herald added a reviewer: luke957. This doesn't apply cleanly to current HEAD, could you please rebase? I think the second part of this that you list, where the ISA extension version becomes optional is undesirable. We made the explicit choice of requiring the version string

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. The test cases are modified because unifying the logic here shows the place where clang / llvm deal with target feature inconsistently. I think it would be beneficial if we have them consistent. - Test cases with `clang -cc1` originally don't do dependency check to target

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 382250. eopXD added a comment. Update code and test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/tes

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 382225. eopXD added a comment. Fix test fail and clang-format error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381873. eopXD edited the summary of this revision. eopXD added a comment. Since parsing logic is unified, code of RISCVAsmParser can be reduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://r

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD created this revision. eopXD added reviewers: kito.cheng, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-