[PATCH] D114502: File Reorganization changes

2021-11-24 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) mehdi_amini wrote: > Is MLIR really coupled to Clang h

[PATCH] D114502: File Reorganization changes

2021-11-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. could you please include a complete diff context in the patch? You can do that by using git diff -U Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HI

[PATCH] D114502: File Reorganization changes

2021-11-24 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153 + set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH}) find_package(HIP) if (NOT HIP_FOUND) Is MLIR really coupled to Clang here? That seems suspi

[PATCH] D114502: File Reorganization changes

2021-11-24 Thread Ranjith Ramakrishnan via Phabricator via cfe-commits
raramakr created this revision. raramakr added reviewers: yaxunl, msearles. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, lucyrfox, mgester, arpith