[PATCH] D116110: Introduce the AttributeMask class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9290ccc3c1a1: Introduce the AttributeMask class (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D116110?vs=3972

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 397225. serge-sans-paille added a comment. rebased on main branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h

[PATCH] D116110: Introduce the AttributeMask class

nikic added a comment. Looking at some of the changes here, I landed a couple of cleanup commits: - https://github.com/llvm/llvm-project/commit/3b0f5a4856fce76a6535feddd1692747b81b60cd (this should fix the build failure) - https://github.com/llvm/llvm-project/commit/e8e8bfeeb7233bde17d0a811b87

[PATCH] D116110: Introduce the AttributeMask class

dexonsmith added a comment. In D116110#3205416 , @nikic wrote: > This looks good to me, but I'd recommend waiting a bit before landing in case > there's further input, as this is a non-trivial API change. (Maybe valuable to start a quick thread on llvm-

[PATCH] D116110: Introduce the AttributeMask class

nikic added a reviewer: aeubanks. nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. This looks good to me, but I'd recommend waiting a bit before landing in case there's further input, as this is a non-trivial API change. I think separating Att

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395713. serge-sans-paille added a comment. Remove `empty()` method and only keep `hasAttributes` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llv

[PATCH] D116110: Introduce the AttributeMask class

nikic added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:992 + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return !TargetDepAttrs.empty() && Attrs.any(); } +}; Shouldn't this be `||`? Comment a

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:993 + + bool empty() const { return Attrs.none(); } + bool hasAttributes() const { return TargetDepAttrs.empty() && Attrs.none(); } ---

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395694. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include/llvm/IR/Attributes.h llvm/include/llvm/IR/Fun

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395692. serge-sans-paille added a comment. Herald added subscribers: foad, kerbowa, nhaehnle, jvesely, arsenm. remvove useless assert, update comment, fix build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm

[PATCH] D116110: Introduce the AttributeMask class

nikic added a comment. Pre-merge checks also report a build failure in llvm/lib/Target/AMDGPU/AMDGPURewriteOutArguments.cpp:360. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 ___ cfe-commits maili

[PATCH] D116110: Introduce the AttributeMask class

nikic added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:956 +assert(Attribute::isEnumAttrKind(Val) && + "Adding integer/type attribute without an argument!"); +Attrs[Val] = true; This assert doesn't make sense to me. Attribute

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille updated this revision to Diff 395677. serge-sans-paille added a comment. Minor nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116110/new/ https://reviews.llvm.org/D116110 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/include/llvm/IR/Argument.h llvm/include

[PATCH] D116110: Introduce the AttributeMask class

serge-sans-paille created this revision. serge-sans-paille added reviewers: nikic, rnk. Herald added subscribers: ormris, dexonsmith, jdoerfert, hiraditya. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.