aeubanks added a comment.
sounds good for the purposes of going back to what we had before, but we should
reconsider the attribute support
Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95
- // Remember to try and delete this function afterward. This both avoids
xbolva00 added a comment.
There is also second use case which I mentioned and I am interested in.
>> I'd vote for properly implementing [1] or removing our support for flatten.
I would rather prefer to restore atleast something which was working before
new PM and then improve it, instead of fu
aeubanks added a comment.
The existing implementation only inlines top level call sites, which doesn't
match gcc where all calls are recursively inlined [1]. gcc's implementation
makes more sense IMO, only inlining top level call sites doesn't seem super
useful.
I'd vote for properly implement
xbolva00 added a comment.
Aiming this fix for LLVM 14.0.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117965/new/
https://reviews.llvm.org/D117965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
xbolva00 added inline comments.
Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95
- // Remember to try and delete this function afterward. This both avoids
- // re-walking the rest of the module and avoids dealing with any iterator
- // invalidation issues
xbolva00 created this revision.
xbolva00 added reviewers: leonardchan, aeubanks.
Herald added subscribers: ormris, hiraditya.
xbolva00 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Problem: Migration to new PM broke flat
