[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-25 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS clang-tidy-headers)

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-25 Thread Jeremy Drake via Phabricator via cfe-commits
jeremyd2019 added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-22 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3e7a8aab759a: [clang-tidy] Dont try to build CTTestTidyModule for Windows with dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-21 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 ___

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-21 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. @rnk Can you have a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121687/new/ https://reviews.llvm.org/D121687 ___ cfe-commits mailing list

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

2022-03-15 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added subscribers: xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. In MinGW mode, it's possible to build LLVM/Clang with