[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

dblaikie added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) aeubanks wrote: > simon_tatham wrot

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0270f6e9583: [clang] Remove Address::deprecated from MveEmitter (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) simon_tatham wrote: > dblaikie wrot

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks updated this revision to Diff 416989. aeubanks added a comment. fix dyn_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046 Files: clang/utils/TableGen/MveEmitter.cpp Index: clang/utils/Tabl

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

simon_tatham added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) dblaikie wrote: > nikic wrote:

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

dblaikie added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) nikic wrote: > Should be either `ca

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Whereas I'm familiar with this code but not with the opaque-pointers effort, so I had to look up the //other// half of what was going on :-) If I've understood this correctly, the

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

dmgreen added a reviewer: simon_tatham. dmgreen added a comment. > I'm very out of my depth with tablegen, let me know if there's a more elegant > way of doing this I think this sounds OK. Providing all the tests pass it looks OK (but I'm not a big expert myself) Repository: rG LLVM Github

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

nikic added inline comments. Comment at: clang/utils/TableGen/MveEmitter.cpp:1197 +const Type *Ty = nullptr; +if (auto *DI = dyn_cast(D->getArg(0))->getOperator()) + if (auto *PTy = dyn_cast(getType(DI, Param))) Should be either `cast` or check for n

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks added a comment. I'm very out of my depth with tablegen, let me know if there's a more elegant way of doing this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122046/new/ https://reviews.llvm.org/D122046 _

[PATCH] D122046: [clang] Remove Address::deprecated from MveEmitter

aeubanks created this revision. Herald added a subscriber: dmgreen. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have to keep track of pointer pointee types with opaque pointers. Repository: r