[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f076004e941: [clang][dataflow] Add support for `value_or` in a comparison. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:275 + State.Env.getValue(*ValueOrPredExpr, SkipPast::None)); + if (ExprValue == nullptr) { +auto =

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:275 + State.Env.getValue(*ValueOrPredExpr, SkipPast::None)); + if (ExprValue == nullptr) { +auto = State.Env.createStorageLocation(*ValueOrPredExpr);

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 419243. ymandel added a comment. delete line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 419240. ymandel marked 5 inline comments as done. ymandel added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, +

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 3 inline comments as done. ymandel added a comment. In D122231#3414109 , @xazax.hun wrote: > Wow. This did take some iterations and I feel like I just added to the > confusion at some point :D But the latest iteration looks much simpler

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Wow. This did take some iterations and I feel like I just added to the confusion at some point :D But the latest iteration looks much simpler and I'm confident it is right this time.

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 7 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:142 + // `opt.value_or(nullptr) != nullptr` and `opt.value_or(0) != 0`. Ideally, + // we'd support this pattern for

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418880. ymandel marked 3 inline comments as done. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > sgatev wrote: > > ymandel wrote: > >

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = sgatev

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > ymandel wrote: > > xazax.hun wrote:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, + Env.makeAnd(*CurrentValue,

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:295 +// atom. +BoolValue = Env.makeAtomicBoolValue(); +return Env.makeOr(Env.makeAnd(HasValueVal, OptionalHoldsEmptyString),

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, + Env.makeAnd(*CurrentValue,

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > xazax.hun wrote: > > xazax.hun

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = xazax.hun wrote: > xazax.hun wrote: > > ymandel

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = xazax.hun wrote: > ymandel wrote: > > xazax.hun

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:307 + [](Environment , BoolValue ) -> BoolValue & { +// We can't reason about general vlaues, so we encode the constraint on +// the

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > xazax.hun wrote: > > Is this the

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = xazax.hun

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:142 + // `opt.value_or(nullptr) != nullptr` and `opt.value_or(0) != 0`. Ideally, + // we'd support this pattern for any expression, but the AST does not have

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418209. ymandel marked an inline comment as done. ymandel added a comment. adjust logical formula Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 6 inline comments as done and an inline comment as not done. ymandel added a comment. Thanks for the detailed review! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:119 + auto NonEmptyStringOptional = unaryOperator( +

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418205. ymandel added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel updated this revision to Diff 418206. ymandel added a comment. remove stray comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122231/new/ https://reviews.llvm.org/D122231 Files:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:269 +// the implication `(opt.value_or(X) != X) => opt.hasValue()`. +State.Env.addToFlowCondition( +

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:119 + auto NonEmptyStringOptional = unaryOperator( + hasOperatorName("!"), + hasUnaryOperand(cxxMemberCallExpr( Why handle negation

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel created this revision. ymandel added reviewers: sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds limited modeling of the `value_or` method.