This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG178aad9b946e: [clang][extract-api] Add Objective-C Category
support (authored by zixuw).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
zixuw updated this revision to Diff 420964.
zixuw added a comment.
Remove extra commas in test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
Files:
clang/include/clang/ExtractAPI/API.h
clang/i
zixuw updated this revision to Diff 420956.
zixuw added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
Files:
clang/include/clang/ExtractAPI/API.h
clang/include/clang/ExtractAPI/Dec
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
___
cf
zixuw updated this revision to Diff 420333.
zixuw marked an inline comment as done.
zixuw added a comment.
Address review comment:
- Use `llvm_unreachable` for the Objective-C category case in
`serializeSymbolKind`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revi
zixuw marked an inline comment as done.
zixuw added inline comments.
Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396
break;
+ case APIRecord::RK_ObjCCategory:
+Kind["identifier"] = AddLangPrefix("category");
dang wrote:
> Si
dang added inline comments.
Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:396
break;
+ case APIRecord::RK_ObjCCategory:
+Kind["identifier"] = AddLangPrefix("category");
Since we currently never actually emit a standalone categ
zixuw updated this revision to Diff 419474.
zixuw added a comment.
Add missing documentatin for ObjCCategoryRecord.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
Files:
clang/include/clang/ExtractAPI/
zixuw updated this revision to Diff 419298.
zixuw added a comment.
Remove probably unnecessary includes added automatically by clangd.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122774/new/
https://reviews.llvm.org/D122774
Files:
clang/includ
zixuw created this revision.
Herald added a reviewer: dang.
Herald added a project: All.
zixuw requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add (partial) support for Objective-C category records in ExtractAPI.
The current ExtractAPI coll
10 matches
Mail list logo