[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. Accidentally added another test case in my local workspace. Removed in 5f841c71fc2cc77c92f526791cd7a938bcac69aa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123831: [clang][extract-api] Use relative includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c262fee08b5: [clang][extract-api] Use relative includes (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 427061. zixuw added a comment. Herald added a subscriber: arphaman. Update test case to use cc1 instead of driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. In D123831#3490684 , @dang wrote: > Since this is a new test can we use the approach in > https://reviews.llvm.org/D124634 to check for diagnostics output. I used FileCheck to check the input buffer dump in this test, but I'll

[PATCH] D123831: [clang][extract-api] Use relative includes

dang added a comment. Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831

[PATCH] D123831: [clang][extract-api] Use relative includes

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426803. zixuw added a comment. - Capture whether the include is quoted in KnownFiles - Misc: use `getInputBufferName()` instead of string literal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/

[PATCH] D123831: [clang][extract-api] Use relative includes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Minor comment LGTM otherwise Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:203 +// Try to reduce the include name the same way we tried to include it. +if

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426547. zixuw added a comment. Convert file path to use slashes for headermap reverse lookup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 Files:

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 426540. zixuw added a comment. - Delete test `known_files_only_hmap` - Handle quoted includes - Attempt to fix Windows fails by converting backslashes before matching the framework regex - Update test `relative_include` Repository: rG LLVM Github Monorepo

[PATCH] D123831: [clang][extract-api] Use relative includes

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + zixuw wrote: > zixuw wrote: > > zixuw wrote: > > > One problem I can see in this right now