[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. In D124556#3482224 , @ken-matsui wrote: > Thank you! Thanks in turn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 __

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce95a1a554: [NFC] Prevent shadowing a variable declared in `if` (authored by ken-matsui, committed by hubert.reinterpretcast). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast I see. Thank you for the detailed information! Could you please commit this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 ___

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. In D124556#3480228 , @ken-matsui wrote: > @hubert.reinterpretcast > > Sorry, I'm a newbie here, but is there anything I should do after getting > approved? I'm not sure if the instructions are a bit out-of-date:

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast Sorry, I'm a newbie here, but is there anything I should do after getting approved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 __

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. Thank you for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast, Thank you for your suggestion! I’ve updated the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 _

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. In D124556#3479833 , @ken-matsui wrote: > @hubert.reinterpretcast, > > Sorry to have missed providing a summary. You can still provide one by using the "Edit Revision" link. I suggest something like: Prevents con

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

ken-matsui added a comment. @hubert.reinterpretcast, Sorry to have missed providing a summary. In most cases, shadowing a declaration of a local variable should be avoided to prevent making others confused and mistakes because we need to figure out the boundaries of the declaration. In this ca

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. @ken-matsui, can you provide some rationale for the change (got compiler warning/error)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 __