sammccall added a comment.
Thanks for revert, and apologies for missing the bots.
(I did of course run the tests locally, but in a weird config that didn't
trigger the failure)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124679/new/
https://rev
thakis added a comment.
This broke check-clangd everywhere, e.g.:
https://lab.llvm.org/buildbot/#/builders/109/builds/37635
http://45.33.8.238/linux/75019/step_9.txt
http://45.33.8.238/macm1/34369/step_9.txt
http://45.33.8.238/win/57278/step_9.txt
Please run tests before committing, please watch
kstoimenov added inline comments.
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:558
+ TU.ClangTidyProvider = addClangArgs({"-Wunused"}, "*");
+ EXPECT_THAT(*TU.build().getDiagnostics(), ElementsAre(UnusedFooWarning));
+ // And we can explicitly exclude a
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5227be8b6aa0: [clangd] More precisely enable clang warnings
through ClangTidy options (authored by sammccall).
Changed prior to commit:
https://re
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/ParsedAST.cpp:240
+// Note that unlike -Wunused, clang-diagnostics-unused does not imply
+// subcategories like clang-d
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-ex
