phyBrackets updated this revision to Diff 426992.
phyBrackets added a comment.
Address inline comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124774/new/
https://reviews.llvm.org/D124774
Files:
clang/include/clang/AST/ASTImportError.h
c
balazske added inline comments.
Comment at: clang/include/clang/AST/ASTImportError.h:1
+//===- ASTImporter.h - Import Error while Importing AST ---*- C++ -*-===//
+//
balazske wrote:
>
Comment at: clang/include/clang/AST/ASTImportError.h:
phyBrackets added inline comments.
Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17
+#include "clang/AST/ASTImportError.h"
#include "clang/AST/DeclBase.h" // lookup_result
balazske wrote:
> phyBrackets wrote:
> > balazske wrote:
> > > This inclu
phyBrackets added inline comments.
Comment at: clang/include/clang/AST/ASTImportError.h:22
+
+class ImportError : public llvm::ErrorInfo {
+public:
balazske wrote:
> balazske wrote:
> > Rename to `ASTImportError`.
> The rename to `ASTImportError` is better in a s
balazske added inline comments.
Comment at: clang/include/clang/AST/ASTImportError.h:17
+
+#include "clang/AST/APValue.h"
+#include "llvm/Support/Error.h"
This header is probably not needed.
Comment at: clang/include/clang/AST/ASTImportError.h:
phyBrackets added inline comments.
Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17
+#include "clang/AST/ASTImportError.h"
#include "clang/AST/DeclBase.h" // lookup_result
balazske wrote:
> This include is not needed here.
Hey thanks for reviewi
