[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rG509b631f84e9: [OpenMP] Try to Infer target triples using the offloading architecture (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:789 + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs().hasArg(options::OPT_offload_arch_EQ)); + if (IsOpenMPOffloading) { yaxunl wrote: > probably sh

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

yaxunl added a comment. could you please add a test to https://github.com/llvm/llvm-project/blob/main/clang/test/Driver/hip-offload-arch.hip to make sure when -fopenmp is specified, no openmp offloading is performed? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:789 + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs().hasArg(options::OPT_offload_arch_EQ)); + if (IsOpenMPOffloading) { probably should be C.getInp

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 __

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 updated this revision to Diff 427599. jhuber6 added a comment. Add test for disabling openmp with `-fno-openmp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 Files: clang/include/clang/Basic/D

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 marked an inline comment as done. jhuber6 added a comment. In D125050#3496289 , @saiislam wrote: > Looks good to me. > > Will it work with `-fno-openmp`? Sometimes `-fno-openmp` is used by the > end-user to override system provided `-fopenmp` fla

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

saiislam added a comment. Looks good to me. Will it work with `-fno-openmp`? Sometimes `-fno-openmp` is used by the end-user to override system provided `-fopenmp` flag for some translation units. Please have a look at following examples: // RUN: %clang -### -target x86_64-linux-gnu \ // R

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && + (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) || + C.getInputArgs()

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 updated this revision to Diff 427496. jhuber6 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125050/new/ https://reviews.llvm.org/D125050 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

tra added a comment. Just a drive-by style review. I didn't look at the functionality of the changes much. Comment at: clang/lib/Driver/Driver.cpp:788-789 + options::OPT_fno_openmp, false) && + (C.getInputArgs().hasArg(options::OPT_fopenmp_ta

[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, yaxunl, JonChesterfield, saiislam, ronlieb. Herald added a subscriber: guansong. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a projec