[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

wangpc planned changes to this revision. wangpc added a comment. I don't have any thoughts on this patch now. In D125765#4511637 , @eopXD wrote: > Sorry for the late reply, I missed this in may mails. > > I see that the motivation start from where you

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

eopXD added a comment. Sorry for the late reply, I missed this in may mails. I see that the motivation start from where you spotted this type alias. However it was essentially just an act for convenience so we don't have to map a more irregular pattern of ( _Float16, float, double) when

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

asb added a reviewer: eopXD. asb added a comment. Adding eop as a reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 ___ cfe-commits mailing list

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

khchen added a comment. In D125765#3526835 , @pcwang-thead wrote: > In D125765#3524456 , @khchen wrote: > >> I think we have no consensus in >>

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead added a comment. In D125765#3524456 , @khchen wrote: > I think we have no consensus in > https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, > and most people disagree the current naming, > maybe we need to

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

khchen added a comment. I think we have no consensus in https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/18#issuecomment-817890161, and most people disagree the current naming, maybe we need to have more followup discussion before landing this patch. For example, maybe `_Float16`

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead updated this revision to Diff 430285. pcwang-thead added a comment. Move to separate RVVHeader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 Files:

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead added a comment. Besides, should we add `vread_csr` and `vwrite_csr` like what in GCC ? These two functions doesn't exist in RVV intrinsics doc, is it a historical problem?

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead updated this revision to Diff 430246. pcwang-thead added a comment. Herald added a subscriber: MaskRay. Add a test to check RVV type aliases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

asb added a comment. Thanks for the patch - can you add test coverage for this please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125765/new/ https://reviews.llvm.org/D125765 ___ cfe-commits mailing

[PATCH] D125765: [RISCV] Add type aliases float16_t, float32_t and float64_t

pcwang-thead created this revision. pcwang-thead added reviewers: asb, luismarques, kito-cheng, craig.topper. Herald added subscribers: sunshaoce, VincentWu, luke957, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,