Hi İsmail,
It looks like we need a new logic to detect a Windows 10 SDK
installation folder. I'll fill the bug about that.
Thank you.
On 11.09.2015 20:11, İsmail Dönmez wrote:
Hi,
On Fri, Sep 11, 2015 at 5:03 PM, Igor Kudrin wrote:
Hi İsmail,
Clang tries to detect pathes automatically on
Hi,
On Fri, Sep 11, 2015 at 5:03 PM, Igor Kudrin wrote:
> Hi İsmail,
>
> Clang tries to detect pathes automatically only if corresponding environment
> variables are not set. In your case, you have these variables set, so clang
> honors them.
In the original case no variable was set, I thought y
Hi İsmail,
Clang tries to detect pathes automatically only if corresponding
environment variables are not set. In your case, you have these
variables set, so clang honors them.
You have only set pathes for VC libraries and Universal CRT, but the
kernel32.lib library is shipped with Windows S
Hi,
C:\Users\ismail\Desktop>set include
INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows
Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows
Kits\NETFXSDK\4.6\inc
Please, can you show the output of the following commands:
1) set include
2) set lib
3) clang-cl.exe -### -fms-compatibility-version=19 foo.cpp
On 11.09.2015 17:44, İsmail Dönmez wrote:
This doesn't seem to work here, VS 2015 on Win 10 x64:
C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibili
This doesn't seem to work here, VS 2015 on Win 10 x64:
C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp
LINK : fatal error LNK1104: cannot open file 'kernel32.lib'
clang-cl.exe: error: linker command failed with exit code 1104 (use -v
to see invocation)
Works fine after
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if available
(authored by rnk).
Changed prior to commit:
http://reviews.llvm.org/D12695?vs=34475&id=34515#toc
Repository:
rL LLVM
http://reviews.llvm.org
ruiu added a comment.
I'm sorry about leave http://reviews.llvm.org/D12604 hanging. I didn't notice
that it got a new review message. Don't mind my patch -- please just submit
when you got LGTM
http://reviews.llvm.org/D12695
___
cfe-commits mailin
ikudrin updated this revision to Diff 34475.
ikudrin added a comment.
- Fixed formatting issues.
- Normalized VariableNames.
- Reworked the useUniversalCRT method to receive a path of Visual Studio.
http://reviews.llvm.org/D12695
Files:
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChains.h
ikudrin added a comment.
In http://reviews.llvm.org/D12695#243552, @rnk wrote:
> There's a bunch of whitespace issues that clang-format can resolve.
Thanks! I'll reformat it.
> We also have the convention that variables are StudlyCaps, which isn't
> followed in a few places.
I've tried to f
rnk added a comment.
There's a bunch of whitespace issues that clang-format can resolve. We also
have the convention that variables are StudlyCaps, which isn't followed in a
few places.
Do you need someone to commit this for you? If so, I can patch this in, test it
manually, and deal with the
ikudrin marked an inline comment as done.
ikudrin added a comment.
In http://reviews.llvm.org/D12695#243320, @rnk wrote:
> FYI @ruiu is moving this code to LLVM in http://reviews.llvm.org/D12604.
Thanks. I think I'll move my changes to the new place when he's finished.
http://reviews.llvm.org
ikudrin updated this revision to Diff 34465.
ikudrin marked an inline comment as done.
ikudrin added a comment.
Just added more context to the patch.
http://reviews.llvm.org/D12695
Files:
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cp
ikudrin updated this revision to Diff 34462.
ikudrin added a comment.
- Extracted a function to convert an architecture type to a library subfolder
name.
- Added a method to check if we should use Universal CRT depending on the
chosen version of Visual Studio.
http://reviews.llvm.org/D12695
F
rnk added a subscriber: ruiu.
rnk added a comment.
FYI @ruiu is moving this code to LLVM in http://reviews.llvm.org/D12604.
Comment at: lib/Driver/MSVCToolChain.cpp:328-340
@@ +327,15 @@
+ llvm::sys::path::append(libPath, "Lib", ucrtVersion, "ucrt");
+ switch (getArch()) {
+
ikudrin created this revision.
ikudrin added a subscriber: cfe-commits.
With Visual Studio 2015 release, a part of runtime library was extracted and
now comes with Windows Kits. This patch enables clang to use Universal CRT
library if %INCLUDE or %LIB environment varaibles are not specified.
S
16 matches
Mail list logo
