[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

This revision was automatically updated to reflect the committed changes. Closed by commit rG869385b11c32: [flang][driver] Add support for `-O{0|1|2|3}` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://revi

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka accepted this revision. rovka added a comment. Cool, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 439285. awarzynski added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Too

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3604037 , @rovka wrote: > I just realized I haven't pestered you enough about testing :) I did feel like I was missing something here, haha! Updates arriving shortly! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka added a comment. I just realized I haven't pestered you enough about testing :) Can you add a test that -O4 indeed warns and uses -O3? Also, the summary says this should work in both the compilation and the frontend driver, but you're only testing with %flang_fc1. Comm

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 439086. awarzynski added a comment. Use `D` instead of `TC.getDriver()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 Files: clang/include/clang/Driver/Options

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:133 + CmdArgs.push_back("-O3"); + TC.getDriver().Diag(diag::warn_O4_is_O3); +} else { peixin wrote: > Nit: I have committed D126164, and you can rebase and use D dir

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. LGTM Comment at: clang/lib/Driver/ToolChains/Flang.cpp:133 + CmdArgs.push_back("-O3"); + TC.getDriver().Diag(diag::warn_O4_is_O3); +} else { Nit: I have committed D126164, and you can rebase and use D directly, which is th

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin accepted this revision. peixin added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Driver/Options.td:732 +def O_flag : Flag<["-"], "O">, Flags<[CC1Option,FC1Option]>, Alias, AliasArgs<["1"]>; def Ofast : Joined<["-"],

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 438995. awarzynski marked 3 inline comments as done. awarzynski added a comment. Address comments from Peixin and Diana Main change - removed ENUM_CODEGENOPT and VALUE_CODEGENOPT from CodeGenOptions.dev. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. Thanks for taking a look, @peixin! Just to clarify - I'm not really looking into `-Os`, `-Ofast` or `-Oz` at the moment. But I'm always happy to review driver patches :) Comment at: clang/include/clang/Driver/Options.td:732 +def O_flag : Flag<["-"]

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

rovka added inline comments. Comment at: flang/include/flang/Frontend/CodeGenOptions.def:12 +// Optionally, the user may also define ENUM_CODEGENOPT (for options +// that have enumeration type and VALUE_CODEGENOPT is a code +// generation option that describes a value rather than

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. Thanks for this patch. This is one big progress to use `flang-new` for real workloads. Mostly looks good to me. I have several minor comments. If supporing `-Ofast` requires more changes, I prefer to push forward with the current patch. summary: fronted -> frontend Conf

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. OK. This seems not to be related to this patch. https://buildkite.com/llvm-project/premerge-checks/builds/98446#0181715d-812b-4d2a-b5d0-5c1283d78b5f I also see these failures in another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3596096 , @peixin wrote: > The CI failed. Thanks - I didn't notice any failures related to this change. Did I miss anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. The CI failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, schweitz, peixin. Herald added subscribers: bzcheeseman, rriddle, mgorny. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscri