[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rGb405407a4899: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D128333?vs=440874=440884#toc Repository: rG LLVM

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440874. awarzynski added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: flang/test/Driver/no-pie.f90:3 + +!- +! RUN COMMANDS awarzynski wrote: > MaskRay wrote: > > The `! RUN COMMANDS` and `EXPECTED

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski updated this revision to Diff 440628. awarzynski added a comment. Update the test following the comments from @MaskRay Also added a comment in Linux.cpp and renamed no-pie.f90 as pic-flags.f90 (to avoid FileCheck matching e.g. `! CHECK: pie` against the file name). Repository: rG

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. In D128333#3613696 , @MaskRay wrote: > True. If it is difficult to override the -pie default from flang side, I am > fine with the code change. Thanks! The proper/long-term fix will require extending Flang's frontend driver

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay added a comment. In D128333#3613665 , @awarzynski wrote: > @MaskRay, thank for taking a look! > > In D128333#3605745 , @MaskRay wrote: > >> gfortran defaults to PIE as well. > > While we strive to be

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. @MaskRay, thank for taking a look! In D128333#3605745 , @MaskRay wrote: > gfortran defaults to PIE as well. While we strive to be compatible with `gfortan`, there's a lot relatively "basic" things still missing in LLVM

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

raghavendhra accepted this revision. raghavendhra added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 ___ cfe-commits mailing list

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

raghavendhra added a reviewer: raghavendhra. raghavendhra added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333 ___ cfe-commits mailing list

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. gfortran defaults to PIE as well. > We can revisit this once support for -fpie and -fpic is available in LLVM > Flang. I'm not aware of anyone actively working in this area.

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. In D128333#3601299 , @kiranchandramohan wrote: > Is the longer-term plan to support this in Flang as well? I don't see why not. AFAIK, the switch in Clang took a while and happened gradually - so we probably shouldn't rush

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

kiranchandramohan added a comment. Is the longer-term plan to support this in Flang as well? Does this affect building object files too or is it just the executable? How would this affect mixed C++/Fortran programs if the Clang and Flang settings are different? Repository: rG LLVM Github

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski created this revision. awarzynski added reviewers: rovka, MaskRay, schweitz, Leporacanthicus. Herald added subscribers: jsji, StephenFan, pengfei, kristof.beyls. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald