[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443771. ychen marked an inline comment as done. ychen added a comment. - fix a bug - update comments - check-all, check-runtimes pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443756. ychen added a comment. - handle more cases to implement DR692, DR1395 - tentatively implement DR1432 which DR692 needs, otherwise there would be regressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, ychen wrot

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, aaron.ballman wrot

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen added a comment. In D128745#3632850 , @aaron.ballman wrote: > Thank you for working on this! Can you please add more details to the patch > summary about the changes? Thanks for taking a look. This was intended to correctly implement https://ee

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

aaron.ballman added reviewers: erichkeane, clang-language-wg. aaron.ballman added a comment. Thank you for working on this! Can you please add more details to the patch summary about the changes? Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mim

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 440703. ychen added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/CXX/drs/dr6xx.cpp

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen created this revision. ychen added reviewers: rsmith, aaron.ballman. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D128745 Files: