pgousseau updated this revision to Diff 34900.
pgousseau added a comment.
Added some comments.
http://reviews.llvm.org/D12901
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.h
t
xazax.hun added a comment.
Hi!
Thank you for the patch!
What happens if you factor the "index + 1" expression out into a separate
variable?
E.g.: unsigned temp = index + 1; and use temp in the condition?
My impression is that, the ranges does not model the overflow behavior
correctly (which i
pgousseau added a comment.
In http://reviews.llvm.org/D12901#248842, @xazax.hun wrote:
> Hi!
>
> Thank you for the patch!
Thanks for reviewing !
> What happens if you factor the "index + 1" expression out into a separate
> variable?
> E.g.: unsigned temp = index + 1; and use temp in the con
pgousseau updated this revision to Diff 35604.
pgousseau added a comment.
Following Gabor's review:
Add a test factoring 'index + 1' in an extra variable.
Let me know if this looks reasonable ?
Regards,
Pierre
http://reviews.llvm.org/D12901
Files:
lib/StaticAnalyzer/Core/RangeConstraintMa
pgousseau added a comment.
Ping !
http://reviews.llvm.org/D12901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
