[PATCH] D130254: [CMake][Clang] Copy folder without permissions

2022-07-22 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. What about similar code in LLVM ? Comment at: clang/cmake/modules/CMakeLists.txt:35 # via CMAKE_MODULE_PATH, place API

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

2022-07-22 Thread Sebastian Neubauer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf359eac5df06: [CMake][Clang] Copy folder without permissions (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

2022-07-21 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. LGMT. Also thanks I saw the same failures and was worried they were not spurious on my own patch. Glad to know they are! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/ https://reviews.llvm.org/D130254

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

2022-07-21 Thread Tom Stellard via Phabricator via cfe-commits
tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Those pre-commit failure seem to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

2022-07-21 Thread Sebastian Neubauer via Phabricator via cfe-commits
sebastian-ne created this revision. sebastian-ne added reviewers: awarzynski, PeteSteinfeld. Herald added a subscriber: mgorny. Herald added a project: All. sebastian-ne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copying the folder