This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc4842bb2e98e: [Clang] Introduce
-fexperimental-sanitize-metadata= (authored by melver).
Changed prior to commit:
https://reviews.llvm.org/D130888?
melver added inline comments.
Comment at: clang/test/Driver/fsanitize-metadata.c:1
+// RUN: %clang --target=x86_64-linux-gnu -fexperimental-sanitize-metadata=all
-fno-experimental-sanitize-metadata=all %s -### 2>&1 | FileCheck %s
+// CHECK-NOT: -fexperimental-sanitize-metadata
-
melver updated this revision to Diff 457779.
melver marked 3 inline comments as done.
melver added a comment.
- Options.td: s/f_clang_Group/f_Group/, remove NoXarchOption
- Driver test: also test -fexperimental-sanitize-metadata=all
-fno-experimental-metadata=
Repository:
rG LLVM Github Monor
MaskRay accepted this revision.
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/Options.td:1687
+def fexperimental_sanitize_metadata_EQ : CommaJoined<["-"],
"fexperimental-sanitize-metadata=">,
+ Group,
+ HelpText<"Specify the type of metadata to emit for
melver updated this revision to Diff 457637.
melver added a comment.
Don't split RUN lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130888/new/
https://reviews.llvm.org/D130888
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/in
vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/Driver/fsanitize-metadata.c:24
+
+// RUN: %clang --target=x86_64-linux-gnu \
+// RUN: -fexperimental-sanitize-metadata=covered,atomics %s
melver updated this revision to Diff 457543.
melver added a comment.
Add CodeGen test.
PTAL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130888/new/
https://reviews.llvm.org/D130888
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/
vitalybuka added a comment.
Another test under llvm-project/clang/test/CodeGen/ is needed which tests IR
generated from C/C++ contains expected info.
Random example clang/test/CodeGen/attr-noundef.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
melver updated this revision to Diff 456608.
melver added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130888/new/
https://reviews.llvm.org/D130888
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Bas
melver updated this revision to Diff 450043.
melver added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130888/new/
https://reviews.llvm.org/D130888
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Bas
melver added inline comments.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:839
+ // Parse -f(no-)?sanitize-metadata.
+ for (const auto *Arg : Args) {
+if (Arg->getOption().matches(
MaskRay wrote:
> Use `Args.getLastArg(...)`
This won't work if someone doe
melver updated this revision to Diff 449671.
melver marked 4 inline comments as done.
melver added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130888/new/
https://reviews.llvm.org/D130888
Files:
clang/include/clang
MaskRay added inline comments.
Comment at: clang/include/clang/Driver/Options.td:5502
MarshallingInfoFlag>;
+def fexperimental_sanitize_metadata_covered
+: Flag<["-"], "fexperimental-sanitize-metadata-covered">,
Let CC1 options use the same spelling as
melver created this revision.
Herald added a subscriber: ormris.
Herald added a project: All.
melver requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Introduces the frontend flag -fexperimental-sanitize-metadata=, which
enables Sanit
14 matches
Mail list logo
