This revision was automatically updated to reflect the committed changes.
Closed by commit rG3c604e9f1560: Update the clang and clang-tools-extra code
owners files (authored by aaron.ballman).
Changed prior to commit:
https://reviews.llvm.org/D132550?vs=457289=458149#toc
Repository:
rG LLVM
jdoerfert added inline comments.
Comment at: clang/CodeOwners.rst:226
+| Alexey Bataev
+| a.bataev\@hotmail.com (email), ABataev (Phabricator), cilkplus (GitHub)
+
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
njames93 added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
+1 to the rst format
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
___
aaron.ballman updated this revision to Diff 457289.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Herald added subscribers: sstefan1, arphaman.
Herald added a reviewer: jdoerfert.
Because I'm touching this file so much anyway to add the GitHub handles, I had
some
alexfh accepted this revision.
alexfh added a comment.
LGTM. Thanks for driving this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
___
cfe-commits mailing
tonic added a comment.
Moving to GitHub PRs is the path forward. Let's save ourselves some work and
add them now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
vsapsai added inline comments.
Comment at: clang/CODE_OWNERS.TXT:128
+H: Bigcheese
+D: Modules & Serialization
I can also help with Modules & Serialization. Maybe more with deserialization
and incorporating the deserialized AST with existing AST.
rengolin accepted this revision.
rengolin added a comment.
W00t!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
___
cfe-commits mailing list
mizvekov added inline comments.
Comment at: clang/CODE_OWNERS.TXT:80
+D: Attributes, Templates
+
N: Reid Kleckner
N: Matheus Izvekov
E: mizve...@gmail.com
H: mizvekov
D: Templates, Type Deduction, Type System
Repository:
rG LLVM Github Monorepo
CHANGES
rsmith accepted this revision.
rsmith added a comment.
LGTM Thank you!
Comment at: clang/CODE_OWNERS.TXT:117
N: Richard Smith
E: rich...@metafoo.co.uk
+D: Emeritus owner
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
NoQ accepted this revision.
NoQ added a comment.
LGTM thanks a lot for handling this!!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
___
cfe-commits mailing
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: clang-tools-extra/CODE_OWNERS.TXT:8
+beautification by scripts. The fields are: name (N), email (E), Phabricator
+handle (H), and description (D).
xazax.hun
xazax.hun accepted this revision.
xazax.hun added inline comments.
This revision is now accepted and ready to land.
Herald added a subscriber: rnkovacs.
Comment at: clang-tools-extra/CODE_OWNERS.TXT:8
+beautification by scripts. The fields are: name (N), email (E), Phabricator
aaron.ballman created this revision.
Herald added a subscriber: yaxunl.
Herald added a project: All.
aaron.ballman requested review of this revision.
Herald added projects: clang, clang-tools-extra.
This corresponds to the RFC posted to Discourse proposing changes for code
ownership in both
15 matches
Mail list logo
