[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. The literal dots have not been escaped as `\.`, but the current change works anyway and the chance of false positives here should be very low. I guess this is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133773: [clang] fix linker executable path in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1848b0a0ed7: [clang] fix linker executable path in test (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/

[PATCH] D133773: [clang] fix linker executable path in test

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github added a comment. @alvinhochun @mstorsjo Let me know if you'd like to see more changes. With the new regex, the tests pass at my end as well as in the Phabricator CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459791. ashay-github added a comment. Updated the regex to `ld{{(.lld)?}}{{(.exe)?}}"`, so that it matches the following sequences: `ld`, `ld.lld`, `ld.exe`, `ld.lld.exe`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459771. ashay-github added a comment. Thanks! I updated the regex to be `ld{{.*}}"`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773 Files:

[PATCH] D133773: [clang] fix linker executable path in test

mstorsjo added a comment. In D133773#3786611 , @alvinhochun wrote: > In D133773#3786602 , @mstorsjo > wrote: > >> In D133773#3786484 , @alvinhochun >> wrote: >> >>> Ah

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. In D133773#3786602 , @mstorsjo wrote: > In D133773#3786484 , @alvinhochun > wrote: > >> Ah sorry about that, I didn't realize the command includes `.exe` on >> Windows. (For the

[PATCH] D133773: [clang] fix linker executable path in test

mstorsjo added a comment. In D133773#3786484 , @alvinhochun wrote: > Ah sorry about that, I didn't realize the command includes `.exe` on Windows. > (For the record, `ld"` matches both `ld` and `ld.lld`.) No, iirc these quotes are checked as literal

[PATCH] D133773: [clang] fix linker executable path in test

alvinhochun added a comment. Ah sorry about that, I didn't realize the command includes `.exe` on Windows. (For the record, `ld"` matches both `ld` and `ld.lld`.) Comment at: clang/test/Driver/mingw-cfguard.c:6 // NO_CF-NOT: "-cfguard-no-checks" -// NO_CF-NEXT: ld" +//

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github created this revision. ashay-github added reviewers: alvinhochun, rnk, mstorsjo, stella.stamenova. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A previous patch