[PATCH] D133807: Update Unicode to 15.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc932cef32aa4: Update Unicode to 15.0 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133807: Update Unicode to 15.0

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thank you, Corentin, and apologies for the delayed review. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. @tahonermann ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 460679. cor3ntin added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/UnicodeCharSets.h

[PATCH] D133807: Update Unicode to 15.0

tahonermann added a comment. > I considered it, and I can add a few if you insist but... I'm not sure adding > random tests tell us much except that the specific tested characters are > supported. I wouldn't expect to learn anything from doing so; it would just provide regression protection

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. In D133807#3792525 , @tahonermann wrote: > Structurally, these changes look like what I would expect. I didn't try to > validate any of the code point ranges. > > Are there useful tests that could be modified or added in order

[PATCH] D133807: Update Unicode to 15.0

tahonermann added a comment. Structurally, these changes look like what I would expect. I didn't try to validate any of the code point ranges. Are there useful tests that could be modified or added in order to validate (probably on a spot check basis) Unicode 15 support for regression

[PATCH] D133807: Update Unicode to 15.0

aaron.ballman added a comment. The changes LGTM, but I'd like to wait for @tahonermann to weigh in with the final acceptance. Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; cor3ntin wrote: >

[PATCH] D133807: Update Unicode to 15.0

cor3ntin added a comment. Thanks for the review Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; shafik wrote: > Maybe I am misunderstanding the comments but should this be `0xa7be`? Quirk of the

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459941. cor3ntin added a comment. Use the name "Unicode 15.0" consistently Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133807: Update Unicode to 15.0

shafik added a comment. Thank you for doing this work. Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713 + // 8 characters + if (C <= 0xa7c2) return C | 1; Maybe I am misunderstanding the comments but should this be `0xa7be`?

[PATCH] D133807: Update Unicode to 15.0

cor3ntin updated this revision to Diff 459877. cor3ntin added a comment. Changelog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133807/new/ https://reviews.llvm.org/D133807 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/UnicodeCharSets.h

[PATCH] D133807: Update Unicode to 15.0

cor3ntin created this revision. Herald added subscribers: hiraditya, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Unicode 15.0 adds 4,489 characters, for a total of