[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > mgorny wrote: > > MaskRay wrote: > > > probinson wrote: > > > > But we _don't_

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added a subscriber: yaxunl. MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) mgorny wrote: > MaskRay wrote: > > probinson wrote: > > > But

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > probinson wrote: > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) probinson wrote: > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're >

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rG1609a5d7715c: [clang] [test] Use %clang_cc1 substitution consistently (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

probinson added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134880/new/ https://reviews.llvm.org/D134880 ___ cfe-commits mailing list

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, jhuber6, davide, asb, MaskRay, plotfi. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,