[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGac135f9ee574: [Clang] Fix using LTO with the new driver in RDC-mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https:/

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 __

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added inline comments. Comment at: clang/test/Driver/hip-phases.hip:553 +// +// RUN: %clang -### --target=x86_64-linux-gnu --offload-new-driver -ccc-print-phases \ +// RUN:--offload-arch=gfx90a --offload-arch=gfx908 -foffload-lto -fgpu-rdc -c %s 2>&1 \ -

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:553 +// +// RUN: %clang -### --target=x86_64-linux-gnu --offload-new-driver -ccc-print-phases \ +// RUN:--offload-arch=gfx90a --offload-arch=gfx908 -foffload-lto -fgpu-rdc -c %s 2>&1 \ --

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 updated this revision to Diff 465584. jhuber6 added a comment. Changing two tests to use phases instead to illustrate the `lto-bc` usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 Files: c

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838490 , @yaxunl wrote: > In D135305#3838435 , @jhuber6 wrote: > >> In D135305#3838412 , @yaxunl wrote: >> >>> should we test with -cc

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added a comment. In D135305#3838435 , @jhuber6 wrote: > In D135305#3838412 , @yaxunl wrote: > >> should we test with -ccc-print-phases instead? It is not clear what actions >> are produced by driver. > > A

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Ah, realized you meant with phases. This is good enough for NVPTX as there is no explic

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Of the four run lines added, three use `-ccc-print-phases`. The last uses just `-###` b

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added a comment. should we test with -ccc-print-phases instead? It is not clear what actions are produced by driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 ___

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driv