[PATCH] D138117: [clang][docs] Correct floating point option explanations

This revision was automatically updated to reflect the committed changes. Closed by commit rG498abe27dcf8: [clang][docs] Correct floating point option explanations (authored by kawashima-fj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam accepted this revision. zahiraam added a comment. This revision is now accepted and ready to land. In D138117#3963560 , @kawashima-fj wrote: > Addressed to @zahiraam's comment Looks good. CHANGES SINCE LAST ACTION

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj updated this revision to Diff 479275. kawashima-fj edited the summary of this revision. kawashima-fj added a comment. Addressed to @zahiraam's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 Files:

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1435 * ``-fno-honor-nans`` - + * ``-fapprox-func`` * ``-fno-math-errno`` Leave a blank line before and after the bullet. Same below. Comment at:

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3933644 , @zahiraam wrote: > What I meant was that the changes about the semantic mode approx-func that > you made here https://reviews.llvm.org/D138109 , should have included the > changes that you are making

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3932688 , @kawashima-fj wrote: > In D138117#3931109 , @zahiraam > wrote: > >> It would probably be better to make these changes with the appropriate code >> changes you are

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. In D138117#3931109 , @zahiraam wrote: > It would probably be better to make these changes with the appropriate code > changes you are making for each semantic mode. And may be keep this patch > only for the other changes

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3930423 , @kawashima-fj wrote: > I don't know it is inteded that `-fno-fast-math` does not imply > `-ftrapping-math` and `-frounding-math`. > `-ffast-math` and `-fno-fast-math` is not symmetric in >

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. It would probably be better to make these changes with the appropriate code changes you are making for each semantic mode. And may be keep this patch only for the other changes you are proposing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. I don't know it is inteded that `-fno-fast-math` does not imply `-ftrapping-math` and `-frounding-math`. `-ffast-math` and `-fno-fast-math` is not symmetric in RenderFloatingPointOptions

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj created this revision. kawashima-fj added reviewers: zahiraam, andrew.w.kaylor. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added a subscriber: cfe-commits. Explanations for options of floating point are