[PATCH] D138426: Fix #58958 on github

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cea4c239570: Do not suggest taking the address of a const pointer to get void* (authored by krsch, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D138426: Fix #58958 on github

dblaikie added a comment. In D138426#3947044 , @aeubanks wrote: > In D138426#3946202 , @krsch wrote: > >> Should I change the title myself or you can change it during commit? If it's >> on me, how do I change it?

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. In D138426#3946202 , @krsch wrote: > Should I change the title myself or you can change it during commit? If it's > on me, how do I change it? `git commit --amend; arc diff`? phabricator isn't very elegant, locally changing the

[PATCH] D138426: Fix #58958 on github

krsch added a comment. Should I change the title myself or you can change it during commit? If it's on me, how do I change it? `git commit --amend; arc diff`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D1384

[PATCH] D138426: Fix #58958 on github

krsch added a comment. Please commit it yourself as I don't have a commit access. This is my first patch here. In D138426#3944472 , @dblaikie wrote: > Do you need me to commit this for you, or can you commit it yourself? Repository: rG LLVM Github M

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. please make the title of the commit say what the commit is actually doing rather than only reference a bug number, the bug number should be in the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ htt

[PATCH] D138426: Fix #58958 on github

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Do you need me to commit this for you, or can you commit it yourself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1384

[PATCH] D138426: Fix #58958 on github

krsch added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrTy->g

[PATCH] D138426: Fix #58958 on github

krsch updated this revision to Diff 477166. krsch added a comment. Check any pointer, not just const. Test for volatile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ https://reviews.llvm.org/D138426 Files: clang/lib/Sema/SemaFixItUti

[PATCH] D138426: Fix #58958 on github

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:135-140 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrTy

[PATCH] D138426: Fix #58958 on github

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrT

[PATCH] D138426: Fix #58958 on github

xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:136-137 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrT

[PATCH] D138426: Fix #58958 on github

krsch added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:135-140 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrTy->g

[PATCH] D138426: Fix #58958 on github

dblaikie added inline comments. Comment at: clang/lib/Sema/SemaFixItUtils.cpp:135-140 +// Do no take address of const pointer to get void* +const PointerType *FromPtrTy = dyn_cast(FromQTy); +const PointerType *ToPtrTy = dyn_cast(ToQTy); +if (FromPtrTy && FromPtrTy

[PATCH] D138426: Fix #58958 on github

krsch created this revision. krsch added reviewers: NoQ, xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: All. krsch requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not suggest to take the address of a const pointe