[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm closed this revision. arsenm added a comment. e630d9b299822810bba8f3d0457004d1b4c39bef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + Joe_Nash

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash accepted this revision. Joe_Nash added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +//

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + Joe_Nash

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + What part

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm created this revision. arsenm added reviewers: yaxunl, b-sumner, JonChesterfield. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: llvm-commits, wdng. Herald added