[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b37e48f6f0: [clang] extend external_source_symbol attribute with USR clause (authored by arphaman). Herald added a project: clang. Changed prior t

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 495202. arphaman added a comment. updated test file with correct version check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Attr.td c

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 495165. arphaman added a comment. - Updated version to be the date. - Updated release notes. - Fixed a bug in my changed tablegen code in previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Fi

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. That part is Ok now, thanks. However, this still needs a release note, plus a test for spelling versions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") =

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 491865. arphaman added a comment. updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Ba

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") =

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variet

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety")

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:962 + let Spellings = [Clang<"external_source_symbol", /*allowInC=*/1, + /*version=*/2>]; let Args = [StringArgument<"language", 1>, erichkeane wrote: > For standa

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/Attr.td:962 + let Spellings = [Clang<"external_source_symbol", /*allowInC=*/1, + /*version=*/2>]; let Args = [StringArgument<"language", 1>, For standards version number

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 490547. arphaman added a comment. Updated `__has_attribute(attribute_external_source_symbol)` to return a version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.t

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > arphaman wrote: > > > a

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > arphaman wrote: > > aaron.ballman wrote: >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + arphaman wrote: > aaron.ballman wrote: > > erichkeane wrote: > > >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > I don't think we can do

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > I don't think we can do this. __has_attrib

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1755 + String that specifies a unified symbol resolution (USR) value for this + declaration. USR string uniquely identifies this particular declaration, and + is typically used when constructin

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane I've added more test coverage with different USR values, C++ decls and some dependent C++ decls too. How does it look now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 _

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 490214. arphaman added a comment. add more test coverage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. I posted the Swift patch here: https://github.com/apple/swift/pull/63002 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Note both the Clang maintainer, and attributes maintainer have requested changes in some way, please let that finish before committing. CHANGES SINCE LAST ACTION https://r

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM, thanks Alex! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. In D141324#4041159 , @arphaman wrote: > In D141324#4039629 , @erichkeane > wrote: > >> I'm disturbed that the string-literal diagnostic you changed never shows up >> in the tests. I

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. In D141324#4039629 , @erichkeane wrote: > I'm disturbed that the string-literal diagnostic you changed never shows up > in the tests. I suspect this attribute needs significantly better test > coverage. Please elaborate. All

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 487944. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. Updated to address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. I'm disturbed that the string-literal diagnostic you changed never shows up in the tests. I suspect this attribute needs significantly better test coverage. Comment at: clang/docs/LanguageExtensions.rst:4815 + +An optional USR string literal can be

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman created this revision. arphaman added reviewers: bnbarham, ravikandhadai. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. Herald added a project: All. arphaman requested review of this revision. Allow the user to specify a concrete USR in the `external_source_